diff mbox

[net] dql: Fix inconsistency between file mode and attr method.

Message ID 20120115021021.1bb055da.shimoda.hiroaki@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Hiroaki SHIMODA Jan. 14, 2012, 5:10 p.m. UTC
There is no store() method for inflight attribute in the
tx-<n>/byte_queue_limits sysfs directory.
So remove S_IWUSR bit.

Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
---
 net/core/net-sysfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Eric Dumazet Jan. 14, 2012, 5:21 p.m. UTC | #1
Le dimanche 15 janvier 2012 à 02:10 +0900, Hiroaki SHIMODA a écrit :
> There is no store() method for inflight attribute in the
> tx-<n>/byte_queue_limits sysfs directory.
> So remove S_IWUSR bit.
> 
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
> ---
>  net/core/net-sysfs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index f3dbd4f..a1727cd 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c
> @@ -929,7 +929,7 @@ static ssize_t bql_show_inflight(struct netdev_queue *queue,
>  }
>  
>  static struct netdev_queue_attribute bql_inflight_attribute =
> -	__ATTR(inflight, S_IRUGO | S_IWUSR, bql_show_inflight, NULL);
> +	__ATTR(inflight, S_IRUGO, bql_show_inflight, NULL);
>  
>  #define BQL_ATTR(NAME, FIELD)						\
>  static ssize_t bql_show_ ## NAME(struct netdev_queue *queue,		\

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Jan. 17, 2012, 3:06 p.m. UTC | #2
From: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Date: Sun, 15 Jan 2012 02:10:21 +0900

> There is no store() method for inflight attribute in the
> tx-<n>/byte_queue_limits sysfs directory.
> So remove S_IWUSR bit.
> 
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>

Applied, with fixed subject line.  It's "bql" not "dql" :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index f3dbd4f..a1727cd 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -929,7 +929,7 @@  static ssize_t bql_show_inflight(struct netdev_queue *queue,
 }
 
 static struct netdev_queue_attribute bql_inflight_attribute =
-	__ATTR(inflight, S_IRUGO | S_IWUSR, bql_show_inflight, NULL);
+	__ATTR(inflight, S_IRUGO, bql_show_inflight, NULL);
 
 #define BQL_ATTR(NAME, FIELD)						\
 static ssize_t bql_show_ ## NAME(struct netdev_queue *queue,		\