From patchwork Fri Jan 13 17:35:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 135946 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A1792B6F65 for ; Sat, 14 Jan 2012 04:55:29 +1100 (EST) Received: from localhost ([::1]:42470 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rll3l-0004dB-Uk for incoming@patchwork.ozlabs.org; Fri, 13 Jan 2012 12:37:01 -0500 Received: from eggs.gnu.org ([140.186.70.92]:58288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rll2J-00010P-8Z for qemu-devel@nongnu.org; Fri, 13 Jan 2012 12:35:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rll2D-0007kc-Ff for qemu-devel@nongnu.org; Fri, 13 Jan 2012 12:35:31 -0500 Received: from thoth.sbs.de ([192.35.17.2]:30855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rll2D-0007gk-1v for qemu-devel@nongnu.org; Fri, 13 Jan 2012 12:35:25 -0500 Received: from mail1.siemens.de (localhost [127.0.0.1]) by thoth.sbs.de (8.13.6/8.13.6) with ESMTP id q0DHZGPP014400; Fri, 13 Jan 2012 18:35:17 +0100 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id q0DHZDOt006138; Fri, 13 Jan 2012 18:35:16 +0100 From: Jan Kiszka To: Avi Kivity , Marcelo Tosatti Date: Fri, 13 Jan 2012 18:35:12 +0100 Message-Id: <4047ac5e25182e51412d272242f4f82b871d5a99.1326476111.git.jan.kiszka@siemens.com> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 192.35.17.2 Cc: Blue Swirl , Anthony Liguori , qemu-devel , kvm@vger.kernel.org, "Michael S. Tsirkin" Subject: [Qemu-devel] [PATCH v6 17/18] kvm: x86: Add user space part for in-kernel IOAPIC X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This introduces the KVM-accelerated IOAPIC model 'kvm-ioapic' and extends the IRQ routing setup by the 0->2 redirection when needed. The kvm-ioapic model has a property that allows to define its GSI base for injecting interrupts into the kernel model. This will allow to disentangle PIC and IOAPIC pins for chipsets that support more sophisticated IRQ routes than the PIIX3. So far the base is kept at 0, i.e. PIC and IOAPIC share pins 0..15. Signed-off-by: Jan Kiszka --- Makefile.target | 2 +- hw/kvm/ioapic.c | 144 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ hw/pc_piix.c | 15 +++++- 3 files changed, 159 insertions(+), 2 deletions(-) create mode 100644 hw/kvm/ioapic.c diff --git a/Makefile.target b/Makefile.target index f49f96e..c82671b 100644 --- a/Makefile.target +++ b/Makefile.target @@ -228,7 +228,7 @@ obj-i386-y += vmport.o obj-i386-y += device-hotplug.o pci-hotplug.o smbios.o wdt_ib700.o obj-i386-y += debugcon.o multiboot.o obj-i386-y += pc_piix.o -obj-i386-$(CONFIG_KVM) += kvm/clock.o kvm/apic.o kvm/i8259.o +obj-i386-$(CONFIG_KVM) += kvm/clock.o kvm/apic.o kvm/i8259.o kvm/ioapic.o obj-i386-$(CONFIG_SPICE) += qxl.o qxl-logger.o qxl-render.o # shared objects diff --git a/hw/kvm/ioapic.c b/hw/kvm/ioapic.c new file mode 100644 index 0000000..3bd388f --- /dev/null +++ b/hw/kvm/ioapic.c @@ -0,0 +1,144 @@ +/* + * KVM in-kernel IOPIC support + * + * Copyright (c) 2011 Siemens AG + * + * Authors: + * Jan Kiszka + * + * This work is licensed under the terms of the GNU GPL version 2. + * See the COPYING file in the top-level directory. + */ + +#include "hw/pc.h" +#include "hw/ioapic_internal.h" +#include "hw/apic_internal.h" +#include "kvm.h" + +typedef struct KVMIOAPICState KVMIOAPICState; + +struct KVMIOAPICState { + IOAPICCommonState ioapic; + uint32_t kvm_gsi_base; +}; + +static void kvm_ioapic_get(KVMIOAPICState *s) +{ + struct kvm_irqchip chip; + struct kvm_ioapic_state *kioapic; + int ret, i; + + chip.chip_id = KVM_IRQCHIP_IOAPIC; + ret = kvm_vm_ioctl(kvm_state, KVM_GET_IRQCHIP, &chip); + if (ret < 0) { + fprintf(stderr, "KVM_GET_IRQCHIP failed: %s\n", strerror(ret)); + abort(); + } + + kioapic = &chip.chip.ioapic; + + s->ioapic.id = kioapic->id; + s->ioapic.ioregsel = kioapic->ioregsel; + s->ioapic.irr = kioapic->irr; + for (i = 0; i < IOAPIC_NUM_PINS; i++) { + s->ioapic.ioredtbl[i] = kioapic->redirtbl[i].bits; + } +} + +static void kvm_ioapic_put(KVMIOAPICState *s) +{ + struct kvm_irqchip chip; + struct kvm_ioapic_state *kioapic; + int ret, i; + + chip.chip_id = KVM_IRQCHIP_IOAPIC; + kioapic = &chip.chip.ioapic; + + kioapic->id = s->ioapic.id; + kioapic->ioregsel = s->ioapic.ioregsel; + kioapic->base_address = s->ioapic.busdev.mmio[0].addr; + kioapic->irr = s->ioapic.irr; + for (i = 0; i < IOAPIC_NUM_PINS; i++) { + kioapic->redirtbl[i].bits = s->ioapic.ioredtbl[i]; + } + + ret = kvm_vm_ioctl(kvm_state, KVM_SET_IRQCHIP, &chip); + if (ret < 0) { + fprintf(stderr, "KVM_GET_IRQCHIP failed: %s\n", strerror(ret)); + abort(); + } +} + +static void kvm_ioapic_pre_save(void *opaque) +{ + KVMIOAPICState *s = opaque; + + kvm_ioapic_get(s); +} + +static int kvm_ioapic_post_load(void *opaque, int version_id) +{ + KVMIOAPICState *s = opaque; + + kvm_ioapic_put(s); + return 0; +} + +static void kvm_ioapic_reset(DeviceState *dev) +{ + KVMIOAPICState *s = DO_UPCAST(KVMIOAPICState, ioapic.busdev.qdev, dev); + + ioapic_reset_common(&s->ioapic); + kvm_ioapic_put(s); +} + +static void kvm_ioapic_set_irq(void *opaque, int irq, int level) +{ + KVMIOAPICState *s = opaque; + int delivered; + + delivered = kvm_irqchip_set_irq(kvm_state, s->kvm_gsi_base + irq, level); + apic_report_irq_delivered(delivered); +} + +static void kvm_ioapic_init(IOAPICCommonState *s, int instance_no) +{ + memory_region_init_reservation(&s->io_memory, "kvm-ioapic", 0x1000); + + qdev_init_gpio_in(&s->busdev.qdev, kvm_ioapic_set_irq, IOAPIC_NUM_PINS); +} + +static const VMStateDescription vmstate_kvm_ioapic = { + .name = "ioapic", + .version_id = IOAPIC_VMSTATE_VERSION, + .minimum_version_id = 1, + .minimum_version_id_old = 1, + .pre_save = kvm_ioapic_pre_save, + .post_load = kvm_ioapic_post_load, + .fields = (VMStateField[]) { + VMSTATE_STRUCT(ioapic, KVMIOAPICState, 0, vmstate_ioapic_common, + IOAPICCommonState), + VMSTATE_END_OF_LIST() + } +}; + +static IOAPICCommonInfo kvm_ioapic_info = { + .busdev.init = ioapic_init_common, + .busdev.qdev.name = "kvm-ioapic", + .busdev.qdev.size = sizeof(KVMIOAPICState), + .busdev.qdev.vmsd = &vmstate_kvm_ioapic, + .busdev.qdev.reset = kvm_ioapic_reset, + .busdev.qdev.no_user = 1, + .busdev.qdev.props = (Property[]) { + DEFINE_PROP_UINT32("gsi_base", KVMIOAPICState, kvm_gsi_base, 0), + DEFINE_PROP_END_OF_LIST() + }, + .init = kvm_ioapic_init, +}; + +static void kvm_ioapic_register_device(void) +{ + sysbus_register_withprop(&kvm_ioapic_info.busdev); +} + +device_init(kvm_ioapic_register_device) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 868f4a5..fcc374f 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -68,6 +68,15 @@ static void kvm_piix3_setup_irq_routing(bool pci_enabled) for (i = 8; i < 16; ++i) { kvm_irqchip_add_route(s, i, KVM_IRQCHIP_PIC_SLAVE, i - 8); } + if (pci_enabled) { + for (i = 0; i < 24; ++i) { + if (i == 0) { + kvm_irqchip_add_route(s, i, KVM_IRQCHIP_IOAPIC, 2); + } else if (i != 2) { + kvm_irqchip_add_route(s, i, KVM_IRQCHIP_IOAPIC, i); + } + } + } ret = kvm_irqchip_commit_routes(s); if (ret < 0) { hw_error("KVM IRQ routing setup failed"); @@ -93,7 +102,11 @@ static void ioapic_init(GSIState *gsi_state) SysBusDevice *d; unsigned int i; - dev = qdev_create(NULL, "ioapic"); + if (kvm_enabled() && kvm_irqchip_in_kernel()) { + dev = qdev_create(NULL, "kvm-ioapic"); + } else { + dev = qdev_create(NULL, "ioapic"); + } qdev_init_nofail(dev); d = sysbus_from_qdev(dev); sysbus_mmio_map(d, 0, 0xfec00000);