From patchwork Fri Jan 13 17:35:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 135936 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B4666B6EFE for ; Sat, 14 Jan 2012 04:35:42 +1100 (EST) Received: from localhost ([::1]:35975 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rll2O-00010b-GK for incoming@patchwork.ozlabs.org; Fri, 13 Jan 2012 12:35:36 -0500 Received: from eggs.gnu.org ([140.186.70.92]:58226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rll2F-00010E-Ez for qemu-devel@nongnu.org; Fri, 13 Jan 2012 12:35:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rll2D-0007k1-AJ for qemu-devel@nongnu.org; Fri, 13 Jan 2012 12:35:27 -0500 Received: from thoth.sbs.de ([192.35.17.2]:30856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rll2C-0007gm-SM for qemu-devel@nongnu.org; Fri, 13 Jan 2012 12:35:25 -0500 Received: from mail1.siemens.de (localhost [127.0.0.1]) by thoth.sbs.de (8.13.6/8.13.6) with ESMTP id q0DHZGRe014267; Fri, 13 Jan 2012 18:35:16 +0100 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id q0DHZDOm006138; Fri, 13 Jan 2012 18:35:16 +0100 From: Jan Kiszka To: Avi Kivity , Marcelo Tosatti Date: Fri, 13 Jan 2012 18:35:05 +0100 Message-Id: <32fe0cb6abacfba9055639e4ac2ae82f3f23231b.1326476111.git.jan.kiszka@siemens.com> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 192.35.17.2 Cc: Blue Swirl , Anthony Liguori , qemu-devel , kvm@vger.kernel.org, "Michael S. Tsirkin" Subject: [Qemu-devel] [PATCH v6 10/18] ioapic: Drop post-load irr initialization X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org As all devices undergo a reset prior to vmloa, and the reset value of irr is 0, we do not need to do this clearing for older vmstates explicitly. Dropping this redundant code will also make KVM integration a bit simpler. Signed-off-by: Jan Kiszka --- hw/ioapic.c | 12 ------------ 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/hw/ioapic.c b/hw/ioapic.c index 27b07c6..0743af6 100644 --- a/hw/ioapic.c +++ b/hw/ioapic.c @@ -278,21 +278,9 @@ ioapic_mem_write(void *opaque, target_phys_addr_t addr, uint64_t val, } } -static int ioapic_post_load(void *opaque, int version_id) -{ - IOAPICState *s = opaque; - - if (version_id == 1) { - /* set sane value */ - s->irr = 0; - } - return 0; -} - static const VMStateDescription vmstate_ioapic = { .name = "ioapic", .version_id = 3, - .post_load = ioapic_post_load, .minimum_version_id = 1, .minimum_version_id_old = 1, .fields = (VMStateField[]) {