Patchwork [v6,10/18] ioapic: Drop post-load irr initialization

login
register
mail settings
Submitter Jan Kiszka
Date Jan. 13, 2012, 5:35 p.m.
Message ID <32fe0cb6abacfba9055639e4ac2ae82f3f23231b.1326476111.git.jan.kiszka@siemens.com>
Download mbox | patch
Permalink /patch/135936/
State New
Headers show

Comments

Jan Kiszka - Jan. 13, 2012, 5:35 p.m.
As all devices undergo a reset prior to vmloa, and the reset value of
irr is 0, we do not need to do this clearing for older vmstates
explicitly. Dropping this redundant code will also make KVM integration
a bit simpler.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 hw/ioapic.c |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

Patch

diff --git a/hw/ioapic.c b/hw/ioapic.c
index 27b07c6..0743af6 100644
--- a/hw/ioapic.c
+++ b/hw/ioapic.c
@@ -278,21 +278,9 @@  ioapic_mem_write(void *opaque, target_phys_addr_t addr, uint64_t val,
     }
 }
 
-static int ioapic_post_load(void *opaque, int version_id)
-{
-    IOAPICState *s = opaque;
-
-    if (version_id == 1) {
-        /* set sane value */
-        s->irr = 0;
-    }
-    return 0;
-}
-
 static const VMStateDescription vmstate_ioapic = {
     .name = "ioapic",
     .version_id = 3,
-    .post_load = ioapic_post_load,
     .minimum_version_id = 1,
     .minimum_version_id_old = 1,
     .fields = (VMStateField[]) {