From patchwork Fri Jan 13 06:33:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Herrenschmidt X-Patchwork-Id: 135723 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EDC22B6FAA for ; Fri, 13 Jan 2012 17:33:59 +1100 (EST) Received: from localhost ([::1]:39923 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlai5-0003Pq-JE for incoming@patchwork.ozlabs.org; Fri, 13 Jan 2012 01:33:57 -0500 Received: from eggs.gnu.org ([140.186.70.92]:58791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlahv-0003Pc-Ja for qemu-devel@nongnu.org; Fri, 13 Jan 2012 01:33:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rlaht-0007Xq-7E for qemu-devel@nongnu.org; Fri, 13 Jan 2012 01:33:47 -0500 Received: from gate.crashing.org ([63.228.1.57]:44928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rlahs-0007Xi-LA for qemu-devel@nongnu.org; Fri, 13 Jan 2012 01:33:45 -0500 Received: from [IPv6:::1] (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id q0D6Xe1b001755; Fri, 13 Jan 2012 00:33:41 -0600 Message-ID: <1326436421.26116.3.camel@pasglop> From: Benjamin Herrenschmidt To: qemu-devel@nongnu.org Date: Fri, 13 Jan 2012 17:33:41 +1100 X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 63.228.1.57 Subject: [Qemu-devel] [PATCH] Endian fix an assertion in usb-msd X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org I stumbled across that one while debugging some other issue... Signed-off-by: Benjamin Herrenschmidt --- hw/usb-msd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-msd.c b/hw/usb-msd.c index e427296..28271fc 100644 --- a/hw/usb-msd.c +++ b/hw/usb-msd.c @@ -195,7 +195,7 @@ static void usb_msd_send_status(MSDState *s, USBPacket *p) DPRINTF("Command status %d tag 0x%x, len %zd\n", s->csw.status, s->csw.tag, p->iov.size); - assert(s->csw.sig == 0x53425355); + assert(s->csw.sig == cpu_to_le32(0x53425355)); len = MIN(sizeof(s->csw), p->iov.size); usb_packet_copy(p, &s->csw, len); memset(&s->csw, 0, sizeof(s->csw));