[wwwdocs] gcc-4.7/porting_to.html

Submitted by Gerald Pfeifer on Jan. 12, 2012, 9:17 p.m.

Details

Message ID alpine.LNX.2.00.1201122204130.7128@zbenl.fvgr
State New
Headers show

Commit Message

Gerald Pfeifer Jan. 12, 2012, 9:17 p.m.
On Wed, 11 Jan 2012, Benjamin Kosnik wrote:
> I thought it better to get this in, warts and all, and have it be
> corrected than to dally around again and have it not checked in.

Awesome.  Seeing the validator errors, I figured I'll try and help, 
alas you only left a single one for me -- patch at the end. :-)


+ At no time, should user-level code use private

Extra comma?

+ The C++ compiler no longer performs an extra unqualified lookups that
+ had performed in the past, namely <a href="http://gcc.gnu.org/PR24163">dependant base class scope lookups</a> and 

Grammaros?

+ C++ programs that depended on the compiler's previous behavior may
+ longer compile. For example, code such as 

"no" missing here. :)

+ <p>
+ To fix this, rename the inner variable from <code>i</code> to a
+ distinct identifier.
+ </p>

"...rename one of the two variables..."

I went ahead and created a small patch with the changes above which
is the second patch below and committed it.  If you'd like to see
some changes, just let me know.

Gerald

Comments

Benjamin Kosnik Jan. 13, 2012, 3:18 p.m.
> I went ahead and created a small patch with the changes above which
> is the second patch below and committed it.  If you'd like to see
> some changes, just let me know.

Thanks Gerald! This looks good.

For the links, I just tried to add them where they'd been added before.
Seems reasonable....

-benjamin

Patch hide | download patch | download mbox

Index: porting_to.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.7/porting_to.html,v
retrieving revision 1.3
diff -u -3 -p -r1.3 porting_to.html
--- porting_to.html	12 Jan 2012 02:52:22 -0000	1.3
+++ porting_to.html	12 Jan 2012 19:30:46 -0000
@@ -204,9 +204,7 @@  int main()
  }
 </pre>
 
-<p>
-Now results in the error:
-<p>
+<p>Now results in the error:</p>
 
 <pre>
 error: redeclaration of &lsquo;int i&rsquo;

Index: porting_to.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.7/porting_to.html,v
retrieving revision 1.5
diff -u -3 -p -r1.5 porting_to.html
--- porting_to.html	12 Jan 2012 19:35:29 -0000	1.5
+++ porting_to.html	12 Jan 2012 21:14:06 -0000
@@ -94,24 +94,25 @@  Fixing this issue is easy: just include 
 <h3>Note on proper checking for thread support</h3>
 
 <p>
-At no time, should user-level code use private
+At no time should user-level code use private
 GCC-implementation-space macros such as
-<code>_GLIBCXX_HAS_GTHREADS</code> to determine at compile-time
-concurrency support. Instead, use the POSIX
-macro <code>_REENTRANT</code>.
+<code>_GLIBCXX_HAS_GTHREADS</code> to determine concurrency support
+at compile-time
+Instead, use the POSIX macro <code>_REENTRANT</code>.
 </p>
 
 <h3>Name lookup changes</h3>
 
 <p>
-The C++ compiler no longer performs an extra unqualified lookups that
-had performed in the past, namely <a href="http://gcc.gnu.org/PR24163">dependant base class scope lookups</a> and
-<a href="http://gcc.gnu.org/PR29131">unqualified template function</a>
+The C++ compiler no longer performs some extra unqualified lookups it
+had performed in the past, namely
+<a href="http://gcc.gnu.org/PR24163">dependant base class scope lookups</a>
+and <a href="http://gcc.gnu.org/PR29131">unqualified template function</a>
 lookups.
 </p>
 
 <p>
-C++ programs that depended on the compiler's previous behavior may
+C++ programs that depended on the compiler's previous behavior may no
 longer compile. For example, code such as
 </p>
 
@@ -195,7 +196,7 @@  error: &lsquo;int i&rsquo; previously de
 </pre>
 
 <p>
-To fix this, rename the inner variable from <code>i</code> to a
+To fix this, rename one of the two variables from <code>i</code> to a
 distinct identifier.
 </p>