From patchwork Thu Jan 12 17:43:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 135662 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 52CDEB6EFE for ; Fri, 13 Jan 2012 04:44:12 +1100 (EST) Received: from localhost ([::1]:47486 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlOh7-0008W0-Gm for incoming@patchwork.ozlabs.org; Thu, 12 Jan 2012 12:44:09 -0500 Received: from eggs.gnu.org ([140.186.70.92]:39685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlOge-0007JQ-Qj for qemu-devel@nongnu.org; Thu, 12 Jan 2012 12:43:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlOgY-00053A-1W for qemu-devel@nongnu.org; Thu, 12 Jan 2012 12:43:40 -0500 Received: from cantor2.suse.de ([195.135.220.15]:43523 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlOgX-00051V-MI; Thu, 12 Jan 2012 12:43:33 -0500 Received: from relay1.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 27B788C061; Thu, 12 Jan 2012 18:43:28 +0100 (CET) From: Alexander Graf To: qemu-devel Developers Date: Thu, 12 Jan 2012 18:43:27 +0100 Message-Id: <1326390207-2650-3-git-send-email-agraf@suse.de> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: <1326390207-2650-1-git-send-email-agraf@suse.de> References: <1326390207-2650-1-git-send-email-agraf@suse.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-Received-From: 195.135.220.15 Cc: Christian Borntraeger , jmforbes@linuxtx.org, qemu-stable@nongnu.org Subject: [Qemu-devel] [PATCH 2/2] s390: fix cpu hotplug / cpu activity on interrupts X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Christian Borntraeger The add_del/running_cpu code and env->halted are tracking stopped cpus. Sleeping cpus (idle and enabled for interrupts) are waiting inside the kernel. No interrupt besides the restart can move a cpu from stopped to operational. This is already handled over there. So lets just remove the bogus wakup from the common interrupt delivery, otherwise any interrupt will wake up a cpu, even if this cpu is stopped (Thus leading to strange hangs on sigp restart) This fixes echo 0 > /sys/devices/system/cpu/cpu0/online echo 1 > /sys/devices/system/cpu/cpu0/online in the guest Signed-off-by: Christian Borntraeger Signed-off-by: Alexander Graf (cherry picked from commit 93116ac0cf9734e7b28886aedf03848b37d6785e) --- target-s390x/kvm.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c index 40b0ab1..b1404bf 100644 --- a/target-s390x/kvm.c +++ b/target-s390x/kvm.c @@ -185,9 +185,6 @@ void kvm_s390_interrupt_internal(CPUState *env, int type, uint32_t parm, return; } - s390_add_running_cpu(env); - qemu_cpu_kick(env); - kvmint.type = type; kvmint.parm = parm; kvmint.parm64 = parm64;