From patchwork Thu Jan 12 15:25:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georg-Johann Lay X-Patchwork-Id: 135640 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 15A07B6EFF for ; Fri, 13 Jan 2012 02:25:35 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1326986736; h=Comment: DomainKey-Signature:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: Content-Type:Content-Transfer-Encoding:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=BHyrFJV3fNbo+CGEMDlliFA0uXM=; b=w1VkpYJZlPv5evn n1CqdZ3M83XjcaB2OkWEKzwbLCL+pYpx+Fa0pJnd34gHor/891uSF5TkzpHaDvlM 62rE/Rh09Kg2IFsy+9PM9mVkr4plcqHaB0SDuy+7sc/HJscJUOK7QvnEFaim9WYc 5Maf+hCYmENGvGZ32rvzV3Gf+FqU= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:X-RZG-AUTH:X-RZG-CLASS-ID:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:Content-Type:Content-Transfer-Encoding:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=pEWhtQ9OQdhn26P5H4qxGaBUKlnLO4i3EwiINrAlLpWthZTwMbC0PxLcv2HZ8i NdvIodwyyBnDwJ1M8/I+7yZSzP7CuFXJ0QFHNY7TIV0vO8+Jmdmqg2MunS/C5WzM XMRVtorU3n3tjBghgoJXp2O/7y0PLGfTkjkISHrodq5bM=; Received: (qmail 15714 invoked by alias); 12 Jan 2012 15:25:31 -0000 Received: (qmail 15703 invoked by uid 22791); 12 Jan 2012 15:25:30 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mo-p00-ob.rzone.de (HELO mo-p00-ob.rzone.de) (81.169.146.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jan 2012 15:25:17 +0000 X-RZG-AUTH: :LXoWVUeid/7A29J/hMvvT2k715jHQaJercGObUOFkj18odoYNahU4Q== X-RZG-CLASS-ID: mo00 Received: from [192.168.0.22] (business-188-111-022-002.static.arcor-ip.net [188.111.22.2]) by post.strato.de (mrclete mo56) (RZmta 27.3 AUTH) with ESMTPA id 502c5ao0CENQ0T ; Thu, 12 Jan 2012 16:25:01 +0100 (MET) Message-ID: <4F0EFB4D.1070106@gjlay.de> Date: Thu, 12 Jan 2012 16:25:01 +0100 From: Georg-Johann Lay User-Agent: Thunderbird 2.0.0.24 (X11/20100302) MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org CC: Denis Chertykov , Eric Weddington Subject: [Patch,AVR] Fix PR51756 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This PR prints a false warning because missing DECL_EXTERNAL test in avr_encode_section_info that checks if progmem variables come with initializer or not. Ok for trunk? PR target/51756 * config/avr/avr.c (avr_encode_section_info): Test for absence of DECL_EXTERNAL when checking for initializers of progmem variables. Johann Index: gcc/config/avr/avr.c =================================================================== --- gcc/config/avr/avr.c (revision 183058) +++ gcc/config/avr/avr.c (working copy) @@ -7222,6 +7222,7 @@ avr_encode_section_info (tree decl, rtx if (new_decl_p && decl && DECL_P (decl) && NULL_TREE == DECL_INITIAL (decl) + && !DECL_EXTERNAL (decl) && avr_progmem_p (decl, DECL_ATTRIBUTES (decl))) { warning (OPT_Wuninitialized,