From patchwork Thu Jan 12 11:23:38 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [RFC, 2/2] hostapd: Subscribe management frames for WPA_IF_AP_BSS types Date: Thu, 12 Jan 2012 01:23:38 -0000 From: Yogesh Ashok Powar X-Patchwork-Id: 135622 Message-Id: <20120112112337.GF16414@hertz.marvell.com> To: Johannes Berg Cc: "j@w1.fi" , "hostap@shmoo.com" On Thu, Jan 12, 2012 at 02:40:24AM -0800, Johannes Berg wrote: > On Thu, 2012-01-12 at 16:03 +0530, Yogesh Ashok Powar wrote: > > In multiple BSSes scenario for the drivers that dont use > > monitor interface and does not implement AP_SME, RX MGMT > > frame subscription happens only for the default bss (first_bss). > > > > Subscribing for RX MGMT frames for such BSSes. > > > > Signed-off-by: Yogesh Ashok Powar > > --- > > src/drivers/driver_nl80211.c | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c > > index 194a752..c4119e3 100644 > > --- a/src/drivers/driver_nl80211.c > > +++ b/src/drivers/driver_nl80211.c > > @@ -7782,6 +7782,10 @@ static int wpa_driver_nl80211_if_add(void *priv, enum wpa_driver_if_type type, > > if (drv_priv) > > *drv_priv = new_bss; > > nl80211_init_bss(new_bss); > > + > > + /* Subscribe management frames for this WPA_IF_AP_BSS */ > > + if (nl80211_setup_ap(new_bss)) > > + return -1; > > That looks right, but shouldn't there be a corresponding teardown_ap()? Yes! Will send V2 with following addition. Thanks Yogesh diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index 1f4a614..68d7ad9 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -7837,6 +7838,7 @@ static int wpa_driver_nl80211_if_remove(void *priv, for (tbss = &drv->first_bss; tbss; tbss = tbss->next) { if (tbss->next == bss) { tbss->next = bss->next; + nl80211_teardown_ap(bss); nl80211_destroy_bss(bss); os_free(bss); bss = NULL;