Patchwork [U-Boot] Please pull u-boot-staging/sr@denx.de - UPDATE

login
register
mail settings
Submitter Stefan Roese
Date Jan. 12, 2012, 7:57 a.m.
Message ID <201201120857.53052.sr@denx.de>
Download mbox
Permalink /patch/135587/
State Rejected
Headers show

Pull-request

git://www.denx.de/git/u-boot-staging.git sr@denx.de

Comments

Stefan Roese - Jan. 12, 2012, 7:57 a.m.
Hi Wolfgang,

please pull Simon's "Unified command execution in one place" patch series
plus one patch from Eric Miao:

The following changes since commit 9a420986cccc9bd2c37affd931d627b3c3e72952:

  ARM: highbank: enable networking and pxe (2012-01-05 20:10:38 +0100)

are available in the git repository at:
  git://www.denx.de/git/u-boot-staging.git sr@denx.de

Eric Miao (1):
      net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

Simon Glass (9):
      Remove CMD_PXE's static on run_command()
      Rename run_command() to builtin_run_command()
      Rename run_command2() to run_command()
      Stop using builtin_run_command()
      Don't include standard parser if hush is used
      Create a single cmd_call() function to handle command execution
      Remove interleave of non-U-Boot code in hush
      Add cmd_process() to process commands in one place
      Convert cmd_usage() calls in common to use a return value

 arch/arm/cpu/arm926ejs/kirkwood/cpu.c |    7 +--
 board/esd/common/cmd_loadpci.c        |    2 +-
 board/esd/du440/du440.c               |    2 +-
 common/cmd_bedbug.c                   |    6 +-
 common/cmd_bmp.c                      |    6 +-
 common/cmd_boot.c                     |    2 +-
 common/cmd_bootm.c                    |   10 +---
 common/cmd_cache.c                    |    4 +-
 common/cmd_dataflash_mmc_mux.c        |    2 +-
 common/cmd_date.c                     |    3 +-
 common/cmd_dcr.c                      |    8 +-
 common/cmd_df.c                       |    2 +-
 common/cmd_eeprom.c                   |    2 +-
 common/cmd_ext2.c                     |    4 +-
 common/cmd_fdc.c                      |    2 +-
 common/cmd_fdos.c                     |    2 +-
 common/cmd_fdt.c                      |   14 ++--
 common/cmd_fitupd.c                   |    2 +-
 common/cmd_flash.c                    |   14 ++--
 common/cmd_fpga.c                     |    4 +-
 common/cmd_gpio.c                     |    2 +-
 common/cmd_i2c.c                      |   32 +++++-----
 common/cmd_ide.c                      |   10 ++--
 common/cmd_irq.c                      |    2 +-
 common/cmd_itest.c                    |    2 +-
 common/cmd_led.c                      |    6 +-
 common/cmd_load.c                     |    2 +-
 common/cmd_log.c                      |    4 +-
 common/cmd_md5sum.c                   |    2 +-
 common/cmd_mdio.c                     |    2 +-
 common/cmd_mem.c                      |   22 ++++----
 common/cmd_mfsl.c                     |   10 ++--
 common/cmd_mgdisk.c                   |    2 +-
 common/cmd_mii.c                      |    4 +-
 common/cmd_misc.c                     |    2 +-
 common/cmd_mmc.c                      |   14 ++--
 common/cmd_mmc_spi.c                  |    3 +-
 common/cmd_mp.c                       |    8 +-
 common/cmd_mtdparts.c                 |    2 +-
 common/cmd_nand.c                     |    6 +-
 common/cmd_net.c                      |    6 +-
 common/cmd_nvedit.c                   |   22 ++++----
 common/cmd_onenand.c                  |   12 ++--
 common/cmd_otp.c                      |    2 +-
 common/cmd_pci.c                      |    2 +-
 common/cmd_portio.c                   |    4 +-
 common/cmd_pxe.c                      |   10 ++--
 common/cmd_reiser.c                   |    4 +-
 common/cmd_sata.c                     |    8 +-
 common/cmd_scsi.c                     |   15 +++--
 common/cmd_setexpr.c                  |    2 +-
 common/cmd_sf.c                       |    2 +-
 common/cmd_sha1sum.c                  |    2 +-
 common/cmd_source.c                   |    2 +-
 common/cmd_strings.c                  |    2 +-
 common/cmd_time.c                     |    4 +-
 common/cmd_ubi.c                      |    4 +-
 common/cmd_ubifs.c                    |   10 ++--
 common/cmd_unzip.c                    |    2 +-
 common/cmd_usb.c                      |    6 +-
 common/command.c                      |   60 ++++++++++++++++++++
 common/hush.c                         |   73 +++++++-----------------
 common/main.c                         |   98 +++++++++++----------------------
 include/command.h                     |   24 ++++++++
 include/common.h                      |    5 +-
 net/eth.c                             |    3 +-
 66 files changed, 312 insertions(+), 307 deletions(-)
Wolfgang Denk - Jan. 13, 2012, 7:28 p.m.
Dear Stefan Roese,

In message <201201120857.53052.sr@denx.de> you wrote:
> Hi Wolfgang,
> 
> please pull Simon's "Unified command execution in one place" patch series
> plus one patch from Eric Miao:
> 
> The following changes since commit 9a420986cccc9bd2c37affd931d627b3c3e72952:
> 
>   ARM: highbank: enable networking and pxe (2012-01-05 20:10:38 +0100)
> 
> are available in the git repository at:
>   git://www.denx.de/git/u-boot-staging.git sr@denx.de
> 
> Eric Miao (1):
>       net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back
> 
> Simon Glass (9):
>       Remove CMD_PXE's static on run_command()
>       Rename run_command() to builtin_run_command()
>       Rename run_command2() to run_command()
>       Stop using builtin_run_command()
>       Don't include standard parser if hush is used
>       Create a single cmd_call() function to handle command execution
>       Remove interleave of non-U-Boot code in hush
>       Add cmd_process() to process commands in one place
>       Convert cmd_usage() calls in common to use a return value

Sorry, but I will not pull these.

Eric's patch has an incomplete andincorrect commit message,
and Simon's pattches seem to messing up the error handling;
see my previous messages.

Thanks anyway for the effort.

Best regards,

Wolfgang Denk