From patchwork Wed Jan 11 17:00:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 135431 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 34A2FB6EF1 for ; Thu, 12 Jan 2012 04:00:44 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757660Ab2AKRAi (ORCPT ); Wed, 11 Jan 2012 12:00:38 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:42648 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756329Ab2AKRAh (ORCPT ); Wed, 11 Jan 2012 12:00:37 -0500 Received: by iabz25 with SMTP id z25so1350440iab.19 for ; Wed, 11 Jan 2012 09:00:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=BKr7CeEXhf1eTYmxt0j/WXdcXtkD8j0OUFHsnwJuHiA=; b=DmkxQzwzbsy33J034iEQwEJ9o8pxouJhTolio4VXOSpLO5hAr1e8+jr8IVtWPn7KQ3 21uYe6LedEfTScAZ5xT1wvE+IZvd9tUJlOLCWlXfRnZ56jpI5ohMfuGr62vELgzcvxeF LeLV2e5caJekWxfk7NX4ck+B/WTf3O4pdBlSA= Received: by 10.43.54.10 with SMTP id vs10mr27103121icb.13.1326301236784; Wed, 11 Jan 2012 09:00:36 -0800 (PST) Received: from larrylap.site (cpe-65-28-92-85.kc.res.rr.com. [65.28.92.85]) by mx.google.com with ESMTPS id cv10sm9840903igc.0.2012.01.11.09.00.34 (version=SSLv3 cipher=OTHER); Wed, 11 Jan 2012 09:00:35 -0800 (PST) Message-ID: <4F0DC030.6090500@lwfinger.net> Date: Wed, 11 Jan 2012 11:00:32 -0600 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111220 Thunderbird/9.0 MIME-Version: 1.0 To: Linus Torvalds CC: Arend van Spriel , "John W. Linville" , Network Development , "Franky (Zhenhui) Lin" , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: brcm80211 breakage.. References: <4F0D6806.4080201@broadcom.com> In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 01/11/2012 10:04 AM, Linus Torvalds wrote: > On Wed, Jan 11, 2012 at 7:05 AM, Linus Torvalds > > Ok, could do it now. But that really doesn't give much more > information. Here it is anyway: > > [ 0.746530] bcma-pci-bridge 0000:02:00.0: PCI INT A -> GSI 17 > (level, low) -> IRQ 17 > [ 0.746544] bcma-pci-bridge 0000:02:00.0: setting latency timer to 64 > [ 0.746617] bcma: Core 0 found: ChipCommon (manuf 0x4BF, id 0x800, > rev 0x22, class 0x0) > [ 0.746646] bcma: Core 1 found: IEEE 802.11 (manuf 0x4BF, id 0x812, > rev 0x17, class 0x0) > [ 0.746709] bcma: Core 2 found: PCIe (manuf 0x4BF, id 0x820, rev > 0x0F, class 0x0) > [ 0.746845] bcma: Switched to core: 0x800 > [ 0.746859] bcma: Found rev 6 PMU (capabilities 0x108C2606) > [ 0.746880] bcma: Switched to core: 0x820 > [ 0.775510] bcma: Switched to core: 0x800 > [ 0.815750] bcma: Unsupported SPROM revision: 255 > [ 0.815804] bcma: No SPROM available I'm not a bcma or brcmsmac expert, but the above result of SPROM version 0xFF looks as if the read was from a non-existent register. If you get a chance, please try this patch, which will dump the offset that is being used. As the TODO indicates, this part is not understood. One other thing to try. If the new output says that the offset is 0x830, try forcing it to 0x800, or vice versa. I don't think you have a 4331, and I expect that the current code is trying 0x830, but should be using 0x800. Larry --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: wireless-testing-new/drivers/bcma/sprom.c =================================================================== --- wireless-testing-new.orig/drivers/bcma/sprom.c +++ wireless-testing-new/drivers/bcma/sprom.c @@ -230,6 +230,7 @@ int bcma_sprom_get(struct bcma_bus *bus) * TODO: understand this condition and use it */ offset = (bus->chipinfo.id == 0x4331) ? BCMA_CC_SPROM : BCMA_CC_SPROM_PCIE6; + pr_debug("SPROM offset 0x%x\n", offset); bcma_sprom_read(bus, offset, sprom); if (bus->chipinfo.id == 0x4331)