From patchwork Wed Jan 11 15:26:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mark Langsdorf X-Patchwork-Id: 135411 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CEA16B6EF7 for ; Thu, 12 Jan 2012 02:27:02 +1100 (EST) Received: from localhost ([::1]:33169 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl04q-0000nU-IC for incoming@patchwork.ozlabs.org; Wed, 11 Jan 2012 10:27:00 -0500 Received: from eggs.gnu.org ([140.186.70.92]:59538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl04L-0007z4-Fy for qemu-devel@nongnu.org; Wed, 11 Jan 2012 10:26:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rl04D-00027l-J4 for qemu-devel@nongnu.org; Wed, 11 Jan 2012 10:26:29 -0500 Received: from smtp181.dfw.emailsrvr.com ([67.192.241.181]:37378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rl04D-000279-AY for qemu-devel@nongnu.org; Wed, 11 Jan 2012 10:26:21 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp18.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 3499C2680BC; Wed, 11 Jan 2012 10:26:19 -0500 (EST) X-Virus-Scanned: OK Received: by smtp18.relay.dfw1a.emailsrvr.com (Authenticated sender: mark.langsdorf-AT-calxeda.com) with ESMTPSA id EF6092683FA; Wed, 11 Jan 2012 10:26:18 -0500 (EST) From: Mark Langsdorf To: qemu-devel@nongnu.org Date: Wed, 11 Jan 2012 09:26:10 -0600 Message-Id: <1326295570-10060-7-git-send-email-mark.langsdorf@calxeda.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1326295570-10060-1-git-send-email-mark.langsdorf@calxeda.com> References: <1326213943-878-1-git-send-email-mark.langsdorf@calxeda.com> <1326295570-10060-1-git-send-email-mark.langsdorf@calxeda.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 67.192.241.181 Cc: i.mitsyanko@gmail.com, peter.maydell@linaro.org, afaerber@suse.de, Mark Langsdorf , edgar.iglesias@gmail.com Subject: [Qemu-devel] =?utf-8?q?=5BPATCH_v8_6/6=5D_arm=3A_Remove_incorrect?= =?utf-8?q?_comment_in_arm=5Ftimer?= X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The current comment says that the arm_timers are restricted to between 32 KHz and 1 MHz, but sp804 TRM does not specify those limits. Signed-off-by: Mark Langsdorf Reviewed-by: Andreas Färber --- Changes from v7 None Changes from v2, v3, v4, v5, v6 Skipped Changes from v1 Clarified the commit message hw/arm_timer.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/arm_timer.c b/hw/arm_timer.c index 60e1c63..15d493f 100644 --- a/hw/arm_timer.c +++ b/hw/arm_timer.c @@ -272,11 +272,8 @@ static int sp804_init(SysBusDevice *dev) qi = qemu_allocate_irqs(sp804_set_irq, s, 2); sysbus_init_irq(dev, &s->irq); - /* The timers are configurable between 32kHz and 1MHz - * defaulting to 1MHz but overrideable as individual properties */ s->timer[0] = arm_timer_init(s->freq0); s->timer[1] = arm_timer_init(s->freq1); - s->timer[0]->irq = qi[0]; s->timer[1]->irq = qi[1]; memory_region_init_io(&s->iomem, &sp804_ops, s, "sp804", 0x1000);