diff mbox

net: bridge: netfilter: Fix dependency for BRIDGE_NF_EBTABLES

Message ID 1326246505-5038-1-git-send-email-festevam@gmail.com
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Fabio Estevam Jan. 11, 2012, 1:48 a.m. UTC
Fix the following build warning:

warning: (BRIDGE_NF_EBTABLES) selects NETFILTER_XTABLES which has unmet direct dependencies (NET && INET && NETFILTER)

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 net/bridge/netfilter/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

stephen hemminger Jan. 11, 2012, 1:52 a.m. UTC | #1
On Tue, 10 Jan 2012 23:48:25 -0200
Fabio Estevam <festevam@gmail.com> wrote:

> Fix the following build warning:
> 
> warning: (BRIDGE_NF_EBTABLES) selects NETFILTER_XTABLES which has unmet direct dependencies (NET && INET && NETFILTER)
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  net/bridge/netfilter/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/bridge/netfilter/Kconfig b/net/bridge/netfilter/Kconfig
> index a9aff9c..9ca621a 100644
> --- a/net/bridge/netfilter/Kconfig
> +++ b/net/bridge/netfilter/Kconfig
> @@ -4,7 +4,7 @@
>  
>  menuconfig BRIDGE_NF_EBTABLES
>  	tristate "Ethernet Bridge tables (ebtables) support"
> -	depends on BRIDGE && NETFILTER
> +	depends on BRIDGE && NETFILTER && INET
>  	select NETFILTER_XTABLES
>  	help
>  	  ebtables is a general, extensible frame/packet identification

Almost everybody has INET defined... but still it should be possible to run ebtables
without INET layer. Looks like a but in XTABLES to me.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Jan. 11, 2012, 6:32 a.m. UTC | #2
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 10 Jan 2012 17:52:51 -0800

> On Tue, 10 Jan 2012 23:48:25 -0200
> Fabio Estevam <festevam@gmail.com> wrote:
> 
>> Fix the following build warning:
>> 
>> warning: (BRIDGE_NF_EBTABLES) selects NETFILTER_XTABLES which has unmet direct dependencies (NET && INET && NETFILTER)
>> 
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>>  net/bridge/netfilter/Kconfig |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/net/bridge/netfilter/Kconfig b/net/bridge/netfilter/Kconfig
>> index a9aff9c..9ca621a 100644
>> --- a/net/bridge/netfilter/Kconfig
>> +++ b/net/bridge/netfilter/Kconfig
>> @@ -4,7 +4,7 @@
>>  
>>  menuconfig BRIDGE_NF_EBTABLES
>>  	tristate "Ethernet Bridge tables (ebtables) support"
>> -	depends on BRIDGE && NETFILTER
>> +	depends on BRIDGE && NETFILTER && INET
>>  	select NETFILTER_XTABLES
>>  	help
>>  	  ebtables is a general, extensible frame/packet identification
> 
> Almost everybody has INET defined... but still it should be possible to run ebtables
> without INET layer. Looks like a but in XTABLES to me.

And this needs to be CC:'d to the netfilter folks meanwhile, added...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/bridge/netfilter/Kconfig b/net/bridge/netfilter/Kconfig
index a9aff9c..9ca621a 100644
--- a/net/bridge/netfilter/Kconfig
+++ b/net/bridge/netfilter/Kconfig
@@ -4,7 +4,7 @@ 
 
 menuconfig BRIDGE_NF_EBTABLES
 	tristate "Ethernet Bridge tables (ebtables) support"
-	depends on BRIDGE && NETFILTER
+	depends on BRIDGE && NETFILTER && INET
 	select NETFILTER_XTABLES
 	help
 	  ebtables is a general, extensible frame/packet identification