Patchwork [v3] add -Wabi to build flags

login
register
mail settings
Submitter Benjamin Kosnik
Date Jan. 9, 2012, 9:56 p.m.
Message ID <20120109135655.035f42c3@shotwell>
Download mbox | patch
Permalink /patch/135115/
State New
Headers show

Comments

Benjamin Kosnik - Jan. 9, 2012, 9:56 p.m.
As requested by Jason, I've added -Wabi to the libstdc++ build flags.
The patch is trivial. The results are in line with what we expect.

After I did this part and verified the build went swimmingly, I ran the
testsuite with -Wabi as well. This part had some problems, I'm getting
some odd results (things like constexpr functions being marked as
changing with -fabi-version=3, which makes no sense to me.)

I've filed this stuff in bugzilla with some notes, see the link for
more info:
http://gcc.gnu.org/PR51804

As an aside, the mangling changes for -fabi-version=3 look like they
will impact a lot of code.

tested x86/linux

-benjamin

Patch

2012-01-09  Benjamin Kosnik  <bkoz@redhat.com>

	    * fragment.am (WARN_CXXFLAGS): Add -Wabi.
	    * Makefile.in: Regenerate.
	    * doc/Makefile.in: Same.
	    * include/Makefile.in: Same.
	    * libsupc++/Makefile.in: Same.
	    * src/Makefile.in: Same.
	    * testsuite/Makefile.in: Same.
	    * po/Makefile.in: Same.
	    * python/Makefile.in: Same.


diff --git a/libstdc++-v3/fragment.am b/libstdc++-v3/fragment.am
index cae1ffd..2bcbc1a 100644
--- a/libstdc++-v3/fragment.am
+++ b/libstdc++-v3/fragment.am
@@ -18,7 +18,7 @@  toolexeclibdir = $(glibcxx_toolexeclibdir)
 CONFIG_CXXFLAGS = \
 	$(SECTION_FLAGS) $(EXTRA_CXX_FLAGS) -frandom-seed=$@
 WARN_CXXFLAGS = \
-	$(WARN_FLAGS) $(WERROR) -fdiagnostics-show-location=once
+	$(WARN_FLAGS) $(WERROR) -fdiagnostics-show-location=once -Wabi
 
 # -I/-D flags to pass when compiling.
 AM_CPPFLAGS = $(GLIBCXX_INCLUDES)