From patchwork Mon Jan 9 18:32:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 135085 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 48257B6FA7 for ; Tue, 10 Jan 2012 05:32:15 +1100 (EST) Received: from localhost ([::1]:44513 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkK0y-0003sy-Os for incoming@patchwork.ozlabs.org; Mon, 09 Jan 2012 13:32:12 -0500 Received: from eggs.gnu.org ([140.186.70.92]:37712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkK0t-0003sr-4p for qemu-devel@nongnu.org; Mon, 09 Jan 2012 13:32:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkK0s-0002X2-1o for qemu-devel@nongnu.org; Mon, 09 Jan 2012 13:32:07 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:54033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkK0r-0002Ww-QP for qemu-devel@nongnu.org; Mon, 09 Jan 2012 13:32:05 -0500 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id B052C7280003; Mon, 9 Jan 2012 19:32:04 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vZFEy-27We+Q; Mon, 9 Jan 2012 19:32:04 +0100 (CET) Received: by v220110690675601.yourvserver.net (Postfix, from userid 1000) id 7A37C7280006; Mon, 9 Jan 2012 19:32:04 +0100 (CET) From: Stefan Weil To: qemu-devel@nongnu.org Date: Mon, 9 Jan 2012 19:32:04 +0100 Message-Id: <1326133924-1621-1-git-send-email-sw@weilnetz.de> X-Mailer: git-send-email 1.7.2.5 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 78.47.199.172 Cc: Stefan Weil Subject: [Qemu-devel] [PATCH] wm8750: Fix calculation of number of array elements X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Coverity says that the division by sizeof(*s->rate) might be wrong. I think that coverity is right. Cc: Andrzej Zaborowski Signed-off-by: Stefan Weil --- hw/wm8750.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/wm8750.c b/hw/wm8750.c index 39383f4..b3589d3 100644 --- a/hw/wm8750.c +++ b/hw/wm8750.c @@ -563,7 +563,7 @@ static void wm8750_pre_save(void *opaque) { WM8750State *s = opaque; - s->rate_vmstate = (s->rate - wm_rate_table) / sizeof(*s->rate); + s->rate_vmstate = s->rate - wm_rate_table; } static int wm8750_post_load(void *opaque, int version_id)