From patchwork Mon Jan 9 15:56:08 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Liguori X-Patchwork-Id: 135058 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DC98DB6FA9 for ; Tue, 10 Jan 2012 02:57:10 +1100 (EST) Received: from localhost ([::1]:51896 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkHap-0003eY-Ga for incoming@patchwork.ozlabs.org; Mon, 09 Jan 2012 10:57:03 -0500 Received: from eggs.gnu.org ([140.186.70.92]:50683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkHac-0003L4-ML for qemu-devel@nongnu.org; Mon, 09 Jan 2012 10:56:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkHaW-000127-AK for qemu-devel@nongnu.org; Mon, 09 Jan 2012 10:56:50 -0500 Received: from e1.ny.us.ibm.com ([32.97.182.141]:32891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkHaW-00011t-7h for qemu-devel@nongnu.org; Mon, 09 Jan 2012 10:56:44 -0500 Received: from /spool/local by e1.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Jan 2012 10:56:42 -0500 Received: from d01relay01.pok.ibm.com (9.56.227.233) by e1.ny.us.ibm.com (192.168.1.101) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 9 Jan 2012 10:56:41 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q09FueaM244308 for ; Mon, 9 Jan 2012 10:56:41 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q09FuevF009551 for ; Mon, 9 Jan 2012 13:56:40 -0200 Received: from titi.austin.rr.com (sig-9-65-217-92.mts.ibm.com [9.65.217.92]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q09FuDUm007421; Mon, 9 Jan 2012 13:56:33 -0200 From: Anthony Liguori To: qemu-devel@nongnu.org Date: Mon, 9 Jan 2012 09:56:08 -0600 Message-Id: <1326124572-8312-7-git-send-email-aliguori@us.ibm.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1326124572-8312-1-git-send-email-aliguori@us.ibm.com> References: <1326124572-8312-1-git-send-email-aliguori@us.ibm.com> x-cbid: 12010915-6078-0000-0000-0000068435DB X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 32.97.182.141 Cc: Anthony Liguori , Luiz Capitulino Subject: [Qemu-devel] [PATCH 07/11] check-qlist: convert to gtest X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Anthony Liguori --- check-qlist.c | 74 ++++++++++++++++++-------------------------------------- configure | 3 +- 2 files changed, 25 insertions(+), 52 deletions(-) diff --git a/check-qlist.c b/check-qlist.c index ee2454a..501ba26 100644 --- a/check-qlist.c +++ b/check-qlist.c @@ -9,7 +9,7 @@ * This work is licensed under the terms of the GNU LGPL, version 2.1 or later. * See the COPYING.LIB file in the top-level directory. */ -#include +#include #include "qint.h" #include "qlist.h" @@ -20,21 +20,20 @@ * (with some violations to access 'private' data) */ -START_TEST(qlist_new_test) +static void qlist_new_test(void) { QList *qlist; qlist = qlist_new(); - fail_unless(qlist != NULL); - fail_unless(qlist->base.refcnt == 1); - fail_unless(qobject_type(QOBJECT(qlist)) == QTYPE_QLIST); + g_assert(qlist != NULL); + g_assert(qlist->base.refcnt == 1); + g_assert(qobject_type(QOBJECT(qlist)) == QTYPE_QLIST); // destroy doesn't exist yet g_free(qlist); } -END_TEST -START_TEST(qlist_append_test) +static void qlist_append_test(void) { QInt *qi; QList *qlist; @@ -46,30 +45,28 @@ START_TEST(qlist_append_test) qlist_append(qlist, qi); entry = QTAILQ_FIRST(&qlist->head); - fail_unless(entry != NULL); - fail_unless(entry->value == QOBJECT(qi)); + g_assert(entry != NULL); + g_assert(entry->value == QOBJECT(qi)); // destroy doesn't exist yet QDECREF(qi); g_free(entry); g_free(qlist); } -END_TEST -START_TEST(qobject_to_qlist_test) +static void qobject_to_qlist_test(void) { QList *qlist; qlist = qlist_new(); - fail_unless(qobject_to_qlist(QOBJECT(qlist)) == qlist); + g_assert(qobject_to_qlist(QOBJECT(qlist)) == qlist); // destroy doesn't exist yet g_free(qlist); } -END_TEST -START_TEST(qlist_destroy_test) +static void qlist_destroy_test(void) { int i; QList *qlist; @@ -81,7 +78,6 @@ START_TEST(qlist_destroy_test) QDECREF(qlist); } -END_TEST static int iter_called; static const int iter_max = 42; @@ -90,16 +86,16 @@ static void iter_func(QObject *obj, void *opaque) { QInt *qi; - fail_unless(opaque == NULL); + g_assert(opaque == NULL); qi = qobject_to_qint(obj); - fail_unless(qi != NULL); - fail_unless((qint_get_int(qi) >= 0) && (qint_get_int(qi) <= iter_max)); + g_assert(qi != NULL); + g_assert((qint_get_int(qi) >= 0) && (qint_get_int(qi) <= iter_max)); iter_called++; } -START_TEST(qlist_iter_test) +static void qlist_iter_test(void) { int i; QList *qlist; @@ -112,42 +108,20 @@ START_TEST(qlist_iter_test) iter_called = 0; qlist_iter(qlist, iter_func, NULL); - fail_unless(iter_called == iter_max); + g_assert(iter_called == iter_max); QDECREF(qlist); } -END_TEST -static Suite *QList_suite(void) +int main(int argc, char **argv) { - Suite *s; - TCase *qlist_public_tcase; + g_test_init(&argc, &argv, NULL); - s = suite_create("QList suite"); + g_test_add_func("/public/new", qlist_new_test); + g_test_add_func("/public/append", qlist_append_test); + g_test_add_func("/public/to_qlist", qobject_to_qlist_test); + g_test_add_func("/public/destroy", qlist_destroy_test); + g_test_add_func("/public/iter", qlist_iter_test); - qlist_public_tcase = tcase_create("Public Interface"); - suite_add_tcase(s, qlist_public_tcase); - tcase_add_test(qlist_public_tcase, qlist_new_test); - tcase_add_test(qlist_public_tcase, qlist_append_test); - tcase_add_test(qlist_public_tcase, qobject_to_qlist_test); - tcase_add_test(qlist_public_tcase, qlist_destroy_test); - tcase_add_test(qlist_public_tcase, qlist_iter_test); - - return s; -} - -int main(void) -{ - int nf; - Suite *s; - SRunner *sr; - - s = QList_suite(); - sr = srunner_create(s); - - srunner_run_all(sr, CK_NORMAL); - nf = srunner_ntests_failed(sr); - srunner_free(sr); - - return (nf == 0) ? EXIT_SUCCESS : EXIT_FAILURE; + return g_test_run(); } diff --git a/configure b/configure index 18f06ba..2ab7d6f 100755 --- a/configure +++ b/configure @@ -2800,10 +2800,9 @@ if test "$softmmu" = yes ; then tools="qemu-ga\$(EXESUF) $tools" fi if [ "$check_utests" = "yes" ]; then - checks="check-qlist" checks="check-qjson $checks" fi - test_progs="$checks check-qdict check-qfloat check-qint check-qstring test-coroutine test-qmp-output-visitor test-qmp-input-visitor" + test_progs="$checks check-qdict check-qfloat check-qint check-qstring check-qlist test-coroutine test-qmp-output-visitor test-qmp-input-visitor" fi fi