Patchwork tcg-arm: fix a typo in comments

login
register
mail settings
Submitter Aurelien Jarno
Date Jan. 7, 2012, 8 p.m.
Message ID <1325966426-475-1-git-send-email-aurelien@aurel32.net>
Download mbox | patch
Permalink /patch/134861/
State New
Headers show

Comments

Aurelien Jarno - Jan. 7, 2012, 8 p.m.
ARM still doesn't support 16GB buffers in 32-bit modes, replace the
16GB by 16MB in the comment.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 exec.c               |    2 +-
 tcg/arm/tcg-target.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Peter Maydell - Jan. 7, 2012, 8:19 p.m.
On 7 January 2012 20:00, Aurelien Jarno <aurelien@aurel32.net> wrote:
> ARM still doesn't support 16GB buffers in 32-bit modes, replace the
> 16GB by 16MB in the comment.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM
Stefan Hajnoczi - Jan. 9, 2012, 12:14 p.m.
On Sat, Jan 07, 2012 at 09:00:25PM +0100, Aurelien Jarno wrote:
> ARM still doesn't support 16GB buffers in 32-bit modes, replace the
> 16GB by 16MB in the comment.
> 
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  exec.c               |    2 +-
>  tcg/arm/tcg-target.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/exec.c b/exec.c
index b1d6602..7f9f730 100644
--- a/exec.c
+++ b/exec.c
@@ -511,7 +511,7 @@  static void code_gen_alloc(unsigned long tb_size)
         if (code_gen_buffer_size > (512 * 1024 * 1024))
             code_gen_buffer_size = (512 * 1024 * 1024);
 #elif defined(__arm__)
-        /* Keep the buffer no bigger than 16GB to branch between blocks */
+        /* Keep the buffer no bigger than 16MB to branch between blocks */
         if (code_gen_buffer_size > 16 * 1024 * 1024)
             code_gen_buffer_size = 16 * 1024 * 1024;
 #elif defined(__s390x__)
diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
index 1d32798..5b233f5 100644
--- a/tcg/arm/tcg-target.c
+++ b/tcg/arm/tcg-target.c
@@ -843,7 +843,7 @@  static inline void tcg_out_st8(TCGContext *s, int cond,
 }
 
 /* The _goto case is normally between TBs within the same code buffer,
- * and with the code buffer limited to 16GB we shouldn't need the long
+ * and with the code buffer limited to 16MB we shouldn't need the long
  * case.
  *
  * .... except to the prologue that is in its own buffer.