From patchwork Fri Jan 6 23:16:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Merrill X-Patchwork-Id: 134713 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 9514AB6F68 for ; Sat, 7 Jan 2012 10:16:27 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1326496588; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Subject: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=WA/KIIx pRfmdLUfayCzodt5K+T4=; b=nOaehFMM2fd/yVQ0FpBJ1yL6mPbGqyM6LsMW/5C JE+a6ErYdnVZgAqMGUOebEeCynlVIRGr3r01CI9LjQZB0AOlyKSXteNtjUaEMbL0 s3W4szUGMoyPGmxJexq0P/xiK6cOEOT4zUKmP/SSrbllSyvP2sAxUYy9gq+7uCIP SBxw= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Subject:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=EinK5CvNHO9ucBTukEbc/OouwfdOTY0igJWNJIrIDfEvbvf2Y2VCJ+SipXn7aX x/FUgaA8JKY51B+Fag6Kv2ymG/7qISMa8anrOqW0EbiAniir9PwRXEzf9UeGriXN XdHSmDWZjFLS/x9zx+HRxS3aubvlVMyxG6Zs6WFsEH7Fk=; Received: (qmail 16770 invoked by alias); 6 Jan 2012 23:16:24 -0000 Received: (qmail 16762 invoked by uid 22791); 6 Jan 2012 23:16:24 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Jan 2012 23:16:04 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q06NG3RQ006052 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 6 Jan 2012 18:16:03 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q06NG31v016758 for ; Fri, 6 Jan 2012 18:16:03 -0500 Received: from [0.0.0.0] (ovpn-113-110.phx2.redhat.com [10.3.113.110]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q06NG1Q5008319 for ; Fri, 6 Jan 2012 18:16:02 -0500 Message-ID: <4F0780B1.6050302@redhat.com> Date: Fri, 06 Jan 2012 18:16:01 -0500 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111112 Thunderbird/8.0 MIME-Version: 1.0 To: gcc-patches List Subject: C++ PATCH for c++/47450 (defining class in new-expression) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org DR 686 clarified that it is ill-formed to define a class in the (type-id) of a new-expression as well as in a new-type-id. This patch implements that, so we now reject the testcase. Tested x86_64-pc-linux-gnu, applying to trunk. commit f9a4c24ed3c76e4777414733d3c7de43c6642286 Author: Jason Merrill Date: Fri Jan 6 17:59:50 2012 -0500 DR 686 PR c++/47450 * parser.c (cp_parser_new_expression): Set type_definition_forbidden_message. diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c index 0ae55a2..9be68d0 100644 --- a/gcc/cp/parser.c +++ b/gcc/cp/parser.c @@ -6668,10 +6668,17 @@ cp_parser_new_expression (cp_parser* parser) if (cp_lexer_next_token_is (parser->lexer, CPP_OPEN_PAREN)) { cp_token *token; + const char *saved_message = parser->type_definition_forbidden_message; + /* Consume the `('. */ cp_lexer_consume_token (parser->lexer); + /* Parse the type-id. */ + parser->type_definition_forbidden_message + = G_("types may not be defined in a new-expression"); type = cp_parser_type_id (parser); + parser->type_definition_forbidden_message = saved_message; + /* Look for the closing `)'. */ cp_parser_require (parser, CPP_CLOSE_PAREN, RT_CLOSE_PAREN); token = cp_lexer_peek_token (parser->lexer); diff --git a/gcc/testsuite/g++.dg/parse/new5.C b/gcc/testsuite/g++.dg/parse/new5.C new file mode 100644 index 0000000..83937c6 --- /dev/null +++ b/gcc/testsuite/g++.dg/parse/new5.C @@ -0,0 +1,4 @@ +// PR c++/47450 + +struct A { }; +A* ap = new(struct: A { }); // { dg-error "types may not be defined" }