Patchwork [v4,1/2] hw/integratorcp: Fix sense of REMAP bit

login
register
mail settings
Submitter Peter Maydell
Date Jan. 6, 2012, 6:58 p.m.
Message ID <1325876308-28097-2-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/134691/
State New
Headers show

Comments

Peter Maydell - Jan. 6, 2012, 6:58 p.m.
Fix the sense of the REMAP bit: 0 should mean "map flash",
1 should mean "map RAM".

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/integratorcp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
andrzej zaborowski - Jan. 10, 2012, 5:35 p.m.
On 6 January 2012 19:58, Peter Maydell <peter.maydell@linaro.org> wrote:
> Fix the sense of the REMAP bit: 0 should mean "map flash",
> 1 should mean "map RAM".

Thanks, applied both patches.

Cheers

Patch

diff --git a/hw/integratorcp.c b/hw/integratorcp.c
index c8f3955..d9d8da3 100644
--- a/hw/integratorcp.c
+++ b/hw/integratorcp.c
@@ -112,7 +112,7 @@  static uint64_t integratorcm_read(void *opaque, target_phys_addr_t offset,
 
 static void integratorcm_do_remap(integratorcm_state *s, int flash)
 {
-    if (flash) {
+    if (!flash) {
         if (s->flash_mapped) {
             sysbus_del_memory(&s->busdev, &s->flash);
             s->flash_mapped = false;