diff mbox

ARM: Fix typo in conversion of ARCH_NR_GPIOS to Kconfig

Message ID 1325795370-21576-1-git-send-email-swarren@nvidia.com
State Not Applicable, archived
Headers show

Commit Message

Stephen Warren Jan. 5, 2012, 8:29 p.m. UTC
Commit 44986ab "ARM: 7240/1: Make ARCH_NR_GPIO a Kconfig variable"
spelled ARCH_NR_GPIOS as ARCH_NR_GPIO, hence making the change
ineffective. This change fixes that.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
This should probably go into 3.3 since the patch it fixes is there. I
don't think this issue affects any Tegra platform, but I didn't investigate
the other platforms that set CONFIG_ARCH_NR_GPIO by default now.

 arch/arm/include/asm/gpio.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Russell King - ARM Linux Jan. 5, 2012, 8:33 p.m. UTC | #1
On Thu, Jan 05, 2012 at 01:29:30PM -0700, Stephen Warren wrote:
> Commit 44986ab "ARM: 7240/1: Make ARCH_NR_GPIO a Kconfig variable"
> spelled ARCH_NR_GPIOS as ARCH_NR_GPIO, hence making the change
> ineffective. This change fixes that.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> This should probably go into 3.3 since the patch it fixes is there. I
> don't think this issue affects any Tegra platform, but I didn't investigate
> the other platforms that set CONFIG_ARCH_NR_GPIO by default now.

Bah, I've just sent my first batch of pull requests to Linus.  Oh well,
things can stay as they are until I send the second set roughly half way
through.  Please stick it in the patch system so it doesn't get forgotten.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Magnus Damm Jan. 13, 2012, 9:55 a.m. UTC | #2
On Fri, Jan 6, 2012 at 5:29 AM, Stephen Warren <swarren@nvidia.com> wrote:
> Commit 44986ab "ARM: 7240/1: Make ARCH_NR_GPIO a Kconfig variable"
> spelled ARCH_NR_GPIOS as ARCH_NR_GPIO, hence making the change
> ineffective. This change fixes that.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> This should probably go into 3.3 since the patch it fixes is there. I
> don't think this issue affects any Tegra platform, but I didn't investigate
> the other platforms that set CONFIG_ARCH_NR_GPIO by default now.

Thanks for this! We would like to see this included in 3.3 to fix
regressions on most ARM shmobile SoCs.

Acked-by: Magnus Damm <damm@opensource.se>
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h
index 7151753..c402e9b 100644
--- a/arch/arm/include/asm/gpio.h
+++ b/arch/arm/include/asm/gpio.h
@@ -2,7 +2,7 @@ 
 #define _ARCH_ARM_GPIO_H
 
 #if CONFIG_ARCH_NR_GPIO > 0
-#define ARCH_NR_GPIO CONFIG_ARCH_NR_GPIO
+#define ARCH_NR_GPIOS CONFIG_ARCH_NR_GPIO
 #endif
 
 /* not all ARM platforms necessarily support this API ... */