Patchwork [U-Boot,PATCHv3,3/8] mkenvimage: Correct the includes and add a missing one

login
register
mail settings
Submitter David Wagner
Date Jan. 5, 2012, 6:44 p.m.
Message ID <1325789099-9260-3-git-send-email-david.wagner@free-electrons.com>
Download mbox | patch
Permalink /patch/134525/
State Changes Requested
Headers show

Comments

David Wagner - Jan. 5, 2012, 6:44 p.m.
compiler.h and u-boot/crc.h need to be included from U-Boot's headers.

stdlib.h was missing.

Signed-off-by: David Wagner <david.wagner@free-electrons.com>
---
 tools/mkenvimage.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Mike Frysinger - Jan. 8, 2012, 6:48 a.m.
On Thursday 05 January 2012 13:44:54 David Wagner wrote:
> --- a/tools/mkenvimage.c
> +++ b/tools/mkenvimage.c
>
> +#include <stdlib.h>
>
> -#include <compiler.h>
> +#include "compiler.h"

these are fine

> -#include <u-boot/crc.h>
> +#include "u-boot/crc.h"

i don't think this is necessary
-mike

Patch

diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c
index 7d33143..bc18736 100644
--- a/tools/mkenvimage.c
+++ b/tools/mkenvimage.c
@@ -31,14 +31,15 @@ 
 #include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
+#include <stdlib.h>
 #include <stdint.h>
 #include <string.h>
 #include <unistd.h>
-#include <compiler.h>
+#include "compiler.h"
 #include <sys/types.h>
 #include <sys/stat.h>
 
-#include <u-boot/crc.h>
+#include "u-boot/crc.h"
 #include <version.h>
 
 #define CRC_SIZE sizeof(uint32_t)