From patchwork Thu Jan 5 13:52:38 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mark Langsdorf X-Patchwork-Id: 134482 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A9F471007D7 for ; Fri, 6 Jan 2012 00:52:44 +1100 (EST) Received: from localhost ([::1]:60001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RinkB-0001UV-97 for incoming@patchwork.ozlabs.org; Thu, 05 Jan 2012 08:52:35 -0500 Received: from eggs.gnu.org ([140.186.70.92]:58148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rink3-0001Pw-3F for qemu-devel@nongnu.org; Thu, 05 Jan 2012 08:52:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rink1-0005QC-3N for qemu-devel@nongnu.org; Thu, 05 Jan 2012 08:52:27 -0500 Received: from smtp111.dfw.emailsrvr.com ([67.192.241.111]:33212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rink0-0005Py-SO for qemu-devel@nongnu.org; Thu, 05 Jan 2012 08:52:25 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp21.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 093B52404C9; Thu, 5 Jan 2012 08:52:24 -0500 (EST) X-Virus-Scanned: OK Received: by smtp21.relay.dfw1a.emailsrvr.com (Authenticated sender: mark.langsdorf-AT-calxeda.com) with ESMTPSA id C565C240483; Thu, 5 Jan 2012 08:52:23 -0500 (EST) From: Mark Langsdorf To: qemu-devel@nongnu.org Date: Thu, 5 Jan 2012 07:52:38 -0600 Message-Id: <1325771559-15570-1-git-send-email-mark.langsdorf@calxeda.com> X-Mailer: git-send-email 1.7.5.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 67.192.241.111 Cc: kwolf@redhat.com, peter.maydell@linaro.org, Rob Herring , afaerber@suse.de, Mark Langsdorf Subject: [Qemu-devel] [PATCH v3 1/2] ahci: convert ahci_reset to use AHCIState X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Rob Herring Use AHCIState instead of AHCIPCIState so the function can be used for non-PCI based AHCI controllers. Signed-off-by: Rob Herring Signed-off-by: Mark Langsdorf Reviewed-by: Andreas Färber Acked-by: Alexander Graf --- Changes from v1, v2 None hw/ide/ahci.c | 14 +++++++------- hw/ide/ich.c | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 0af201d..135d0ee 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -336,7 +336,7 @@ static void ahci_mem_write(void *opaque, target_phys_addr_t addr, case HOST_CTL: /* R/W */ if (val & HOST_CTL_RESET) { DPRINTF(-1, "HBA Reset\n"); - ahci_reset(container_of(s, AHCIPCIState, ahci)); + ahci_reset(s); } else { s->control_regs.ghc = (val & 0x3) | HOST_CTL_AHCI_EN; ahci_check_irq(s); @@ -1199,18 +1199,18 @@ void ahci_uninit(AHCIState *s) void ahci_reset(void *opaque) { - struct AHCIPCIState *d = opaque; + struct AHCIState *s = opaque; AHCIPortRegs *pr; int i; - d->ahci.control_regs.irqstatus = 0; - d->ahci.control_regs.ghc = 0; + s->control_regs.irqstatus = 0; + s->control_regs.ghc = 0; - for (i = 0; i < d->ahci.ports; i++) { - pr = &d->ahci.dev[i].port_regs; + for (i = 0; i < s->ports; i++) { + pr = &s->dev[i].port_regs; pr->irq_stat = 0; pr->irq_mask = 0; pr->scr_ctl = 0; - ahci_reset_port(&d->ahci, i); + ahci_reset_port(s, i); } } diff --git a/hw/ide/ich.c b/hw/ide/ich.c index 3f7510f..44363ec 100644 --- a/hw/ide/ich.c +++ b/hw/ide/ich.c @@ -102,7 +102,7 @@ static int pci_ich9_ahci_init(PCIDevice *dev) /* XXX Software should program this register */ d->card.config[0x90] = 1 << 6; /* Address Map Register - AHCI mode */ - qemu_register_reset(ahci_reset, d); + qemu_register_reset(ahci_reset, &d->ahci); msi_init(dev, 0x50, 1, true, false); d->ahci.irq = d->card.irq[0]; @@ -133,7 +133,7 @@ static int pci_ich9_uninit(PCIDevice *dev) d = DO_UPCAST(struct AHCIPCIState, card, dev); msi_uninit(dev); - qemu_unregister_reset(ahci_reset, d); + qemu_unregister_reset(ahci_reset, &d->ahci); ahci_uninit(&d->ahci); return 0;