[v2] drivers: net: Fix dependency for EEPROM_93CX6

Fix the following build warning:

warning: (KS8851 && AX88796_93CX6 && RTL8180 && RTL8187 && ADM8211 && RT2400PCI && RT2500PCI && RT61PCI && RT2800PCI && R8187SE) selects EEPROM_93CX6 which has unmet direct dependencies (MISC_DEVICES)

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Place MISC_DEVICES dependency into the 'depends on' line

 drivers/net/ethernet/8390/Kconfig    |    2 +-
 drivers/net/wireless/Kconfig         |    2 +-
 drivers/net/wireless/rt2x00/Kconfig  |    7 ++++---
 drivers/net/wireless/rtl818x/Kconfig |    4 ++--
 4 files changed, 8 insertions(+), 7 deletions(-)

On 01/05/2012 07:37 AM, Fabio Estevam wrote:
> Fix the following build warning:
>
> warning: (KS8851&&  AX88796_93CX6&&  RTL8180&&  RTL8187&&  ADM8211&&  RT2400PCI&&  RT2500PCI&&  RT61PCI&&  RT2800PCI&&  R8187SE) selects EEPROM_93CX6 which has unmet direct dependencies (MISC_DEVICES)
>
> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Place MISC_DEVICES dependency into the 'depends on' line

Is this the right way to fix this? Whenever I get this kind of build warning, I 
usually attribute it to a problem with my local configuration and fix my copy of 
.config, not modify the build system. With this change, it seems to me that a 
lot of devices will suddenly disappear from the build with little explanation. I 
don't feel confident enough to NACK the patch, but I would like an expert to 
comment.

I have noticed that the defconfigs for various architectures are split between 
turning MISC_DEVICES on or off.

Larry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Thu, 2012-01-05 at 10:11 -0600, Larry Finger wrote:
> On 01/05/2012 07:37 AM, Fabio Estevam wrote:
> > Fix the following build warning:
> >
> > warning: (KS8851&&  AX88796_93CX6&&  RTL8180&&  RTL8187&&  ADM8211&&  RT2400PCI&&  RT2500PCI&&  RT61PCI&&  RT2800PCI&&  R8187SE) selects EEPROM_93CX6 which has unmet direct dependencies (MISC_DEVICES)
> >
> > Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>
> > ---
> > Changes since v1:
> > - Place MISC_DEVICES dependency into the 'depends on' line
> 
> Is this the right way to fix this? Whenever I get this kind of build warning, I 
> usually attribute it to a problem with my local configuration and fix my copy of 
> .config, not modify the build system. With this change, it seems to me that a 
> lot of devices will suddenly disappear from the build with little explanation.

I entirely agree.

> I don't feel confident enough to NACK the patch, but I would like an expert to 
> comment.

I'm not an expert but am prepared to be opinionated!

> I have noticed that the defconfigs for various architectures are split between 
> turning MISC_DEVICES on or off.

That seems like a bug, since MISC_DEVICES doesn't by itself select any
code.  (It's also not a meaningful category and maybe ought not to be an
option at all.)

Ben.

From: Larry Finger <Larry.Finger@lwfinger.net>
Date: Thu, 05 Jan 2012 10:11:21 -0600

> On 01/05/2012 07:37 AM, Fabio Estevam wrote:
>> Fix the following build warning:
>>
>> warning: (KS8851&& AX88796_93CX6&& RTL8180&& RTL8187&& ADM8211&&
>> RT2400PCI&& RT2500PCI&& RT61PCI&& RT2800PCI&& R8187SE) selects
>> EEPROM_93CX6 which has unmet direct dependencies (MISC_DEVICES)
>>
>> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>
>> ---
>> Changes since v1:
>> - Place MISC_DEVICES dependency into the 'depends on' line
> 
> Is this the right way to fix this? Whenever I get this kind of build
> warning, I usually attribute it to a problem with my local
> configuration and fix my copy of .config, not modify the build
> system. With this change, it seems to me that a lot of devices will
> suddenly disappear from the build with little explanation. I don't
> feel confident enough to NACK the patch, but I would like an expert to
> comment.
> 
> I have noticed that the defconfigs for various architectures are split
> between turning MISC_DEVICES on or off.

Right, this is definitely the wrong fix, "select" is the right way to
fix this because no user should have to know the gory details of what
random odd config variables have to be on already in order to turn on
support for a device they are interested in.

Fix this right, by using "select MISC_DEVICES"
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Thu, Jan 5, 2012 at 3:20 PM, David Miller <davem@davemloft.net> wrote:

> Right, this is definitely the wrong fix, "select" is the right way to
> fix this because no user should have to know the gory details of what
> random odd config variables have to be on already in order to turn on
> support for a device they are interested in.
>
> Fix this right, by using "select MISC_DEVICES"

I have tried selecting MISC_DEVICES in the Kconfig's, but the warning remains.

I agree with Ben's comment: "That seems like a bug, since MISC_DEVICES
doesn't by itself select any
code.  (It's also not a meaningful category and maybe ought not to be an
option at all.)"

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html