Patchwork [U-Boot,v2,14/17] x86: Move setup_pcat_compatibility() out of board.c

login
register
mail settings
Submitter Graeme Russ
Date Jan. 4, 2012, 7:59 p.m.
Message ID <1325707195-3218-14-git-send-email-graeme.russ@gmail.com>
Download mbox | patch
Permalink /patch/134350/
State Awaiting Upstream
Delegated to: Graeme Russ
Headers show

Comments

Graeme Russ - Jan. 4, 2012, 7:59 p.m.
This function simply does not belong in board.c

Signed-off-by: Graeme Russ <graeme.russ@gmail.com>
---
Changes for v2:
 - Added commit message

 arch/x86/lib/board.c  |    7 -------
 arch/x86/lib/zimage.c |    7 +++++++
 2 files changed, 7 insertions(+), 7 deletions(-)

--
1.7.5.2.317.g391b14
Simon Glass - Jan. 12, 2012, 5:02 a.m.
On Wed, Jan 4, 2012 at 11:59 AM, Graeme Russ <graeme.russ@gmail.com> wrote:
> This function simply does not belong in board.c
>
> Signed-off-by: Graeme Russ <graeme.russ@gmail.com>

Acked-by: Simon Glass <sjg@chromium.org>

> ---
> Changes for v2:
>  - Added commit message
>
>  arch/x86/lib/board.c  |    7 -------
>  arch/x86/lib/zimage.c |    7 +++++++
>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/x86/lib/board.c b/arch/x86/lib/board.c
> index aaffd1b..416aa9e 100644
> --- a/arch/x86/lib/board.c
> +++ b/arch/x86/lib/board.c
> @@ -486,10 +486,3 @@ void hang(void)
>        for (;;)
>                ;
>  }
> -
> -void setup_pcat_compatibility(void)
> -       __attribute__((weak, alias("__setup_pcat_compatibility")));
> -
> -void __setup_pcat_compatibility(void)
> -{
> -}
> diff --git a/arch/x86/lib/zimage.c b/arch/x86/lib/zimage.c
> index bb40517..2214286 100644
> --- a/arch/x86/lib/zimage.c
> +++ b/arch/x86/lib/zimage.c
> @@ -314,6 +314,13 @@ void boot_zimage(void *setup_base, void *load_address)
>  #endif
>  }
>
> +void setup_pcat_compatibility(void)
> +       __attribute__((weak, alias("__setup_pcat_compatibility")));
> +
> +void __setup_pcat_compatibility(void)
> +{
> +}
> +
>  int do_zboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
>  {
>        struct boot_params *base_ptr;
> --
> 1.7.5.2.317.g391b14
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Patch

diff --git a/arch/x86/lib/board.c b/arch/x86/lib/board.c
index aaffd1b..416aa9e 100644
--- a/arch/x86/lib/board.c
+++ b/arch/x86/lib/board.c
@@ -486,10 +486,3 @@  void hang(void)
 	for (;;)
 		;
 }
-
-void setup_pcat_compatibility(void)
-	__attribute__((weak, alias("__setup_pcat_compatibility")));
-
-void __setup_pcat_compatibility(void)
-{
-}
diff --git a/arch/x86/lib/zimage.c b/arch/x86/lib/zimage.c
index bb40517..2214286 100644
--- a/arch/x86/lib/zimage.c
+++ b/arch/x86/lib/zimage.c
@@ -314,6 +314,13 @@  void boot_zimage(void *setup_base, void *load_address)
 #endif
 }

+void setup_pcat_compatibility(void)
+	__attribute__((weak, alias("__setup_pcat_compatibility")));
+
+void __setup_pcat_compatibility(void)
+{
+}
+
 int do_zboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 {
 	struct boot_params *base_ptr;