[trans-mem] remove xfail for tm alias testcases

Submitted by Patrick Marlier on Jan. 4, 2012, 4:51 p.m.

Details

Message ID 4F048395.4060103@gmail.com
State New
Headers show

Commit Message

Patrick Marlier Jan. 4, 2012, 4:51 p.m.
(From a old email in sent after the merge)

The output for "ealias" was changed in revision 158374.
	* tree-ssa-structalias.c
	(dump_solution_for_var): Always dump the solution.
Example
before: pp = same as mystruct
after:  pp = { ESCAPED NONLOCAL } same as mystruct

So the patch adjusts the output to be checked in the testcases and 
remove the xfail.

Tested on i686.
Ok to commit?
(don't have an account yet, thanks in advance for committer)

Patrick Marlier.
2012-01-04  Patrick Marlier  <patrick.marlier@gmail.com>

	* gcc.dg/tm/alias-1.c:  Adjust regexp.
	* gcc.dg/tm/alias-2.c:  Adjust regexp.

Comments

Aldy Hernandez Jan. 4, 2012, 4:55 p.m.
On 01/04/12 10:51, Patrick Marlier wrote:
> (From a old email in sent after the merge)
>
> The output for "ealias" was changed in revision 158374.
> * tree-ssa-structalias.c
> (dump_solution_for_var): Always dump the solution.
> Example
> before: pp = same as mystruct
> after: pp = { ESCAPED NONLOCAL } same as mystruct
>
> So the patch adjusts the output to be checked in the testcases and
> remove the xfail.
>
> Tested on i686.
> Ok to commit?
> (don't have an account yet, thanks in advance for committer)

Absolutely!  OK as obvious.

Thanks.

I will commit.  Is there a PR associated with this so we can close it as 
well?
Patrick Marlier Jan. 4, 2012, 4:59 p.m.
I have just realized that there are bugreports for them.
So here the ChangeLog adjusted.

Patrick.

On 01/04/2012 11:51 AM, Patrick Marlier wrote:
> (From a old email in sent after the merge)
>
> The output for "ealias" was changed in revision 158374.
> * tree-ssa-structalias.c
> (dump_solution_for_var): Always dump the solution.
> Example
> before: pp = same as mystruct
> after: pp = { ESCAPED NONLOCAL } same as mystruct
>
> So the patch adjusts the output to be checked in the testcases and
> remove the xfail.
>
> Tested on i686.
> Ok to commit?
> (don't have an account yet, thanks in advance for committer)
>
> Patrick Marlier.
>
2012-01-04  Patrick Marlier  <patrick.marlier@gmail.com>

	PR other/51163
	PR other/51164
	* gcc.dg/tm/alias-1.c:  Adjust regexp.
	* gcc.dg/tm/alias-2.c:  Adjust regexp.
Aldy Hernandez Jan. 4, 2012, 5:06 p.m.
On 01/04/12 10:59, Patrick Marlier wrote:
> I have just realized that there are bugreports for them.
> So here the ChangeLog adjusted.

Adjusted, committed, and closed both PRs.

Thanks.

Patch hide | download patch | download mbox

Index: gcc.dg/tm/alias-1.c
===================================================================
--- gcc.dg/tm/alias-1.c	(revision 182878)
+++ gcc.dg/tm/alias-1.c	(working copy)
@@ -34,7 +34,7 @@  void f(void)
 }
 
 /* { dg-final { scan-tree-dump-times "mystruct = \{ .*ESCAPED" 1 "ealias" } } */
-/* { dg-final { scan-tree-dump-times "someptr = same as mystruct" 1 "ealias" { xfail *-*-* } } } */
-/* { dg-final { scan-tree-dump-times "ui\..* = same as mystruct" 1 "ealias" { xfail *-*-* } } } */
-/* { dg-final { scan-tree-dump-times "pp\..* = same as mystruct" 1 "ealias" { xfail *-*-* } } } */
+/* { dg-final { scan-tree-dump-times "someptr = .*same as mystruct" 1 "ealias" } } */
+/* { dg-final { scan-tree-dump-times "ui\..* = .*same as mystruct" 1 "ealias" } } */
+/* { dg-final { scan-tree-dump-times "pp\..* = .*same as mystruct" 1 "ealias" } } */
 /* { dg-final { cleanup-tree-dump "ealias" } } */
Index: gcc.dg/tm/alias-2.c
===================================================================
--- gcc.dg/tm/alias-2.c	(revision 182878)
+++ gcc.dg/tm/alias-2.c	(working copy)
@@ -36,7 +36,7 @@  void foo()
   candy();
 }
 
-/* { dg-final { scan-tree-dump-times "ui\..* = same as mystruct" 1 "ealias" { xfail *-*-* } } } */
+/* { dg-final { scan-tree-dump-times "ui\..* = .*same as mystruct" 1 "ealias" } } */
 /* { dg-final { scan-tree-dump-times "mystruct.*ESCAPED" 1 "ealias" } } */
-/* { dg-final { scan-tree-dump-times "pp = same as mystruct" 1 "ealias" { xfail *-*-* } } } */
+/* { dg-final { scan-tree-dump-times "pp = .*same as mystruct" 1 "ealias" } } */
 /* { dg-final { cleanup-tree-dump "ealias" } } */