Patchwork [1/1] SCHED: netem: Correct documentation comment in code.

login
register
mail settings
Submitter Jesper Dangaard Brouer
Date Dec. 11, 2008, 1:18 p.m.
Message ID <1229001489.18280.179.camel@localhost.localdomain>
Download mbox | patch
Permalink /patch/13427/
State Accepted
Delegated to: David Miller
Headers show

Comments

Jesper Dangaard Brouer - Dec. 11, 2008, 1:18 p.m.
The netem simulator is no longer limited by Linux timer resolution HZ.
Not since Patrick McHardy changed the QoS system to use hrtimer.

Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---
 net/sched/sch_netem.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
stephen hemminger - Dec. 11, 2008, 5:21 p.m.
On Thu, 11 Dec 2008 14:18:09 +0100
Jesper Dangaard Brouer <hawk@comx.dk> wrote:

> 
> The netem simulator is no longer limited by Linux timer resolution HZ.
> Not since Patrick McHardy changed the QoS system to use hrtimer.
> 
> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

That depends if HIGH_RES_TIMERS are configured.

Acked-by: Stephen Hemminger <shemminger@vyatta.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Dec. 15, 2008, 8:39 a.m.
From: Jesper Dangaard Brouer <hawk@comx.dk>
Date: Thu, 11 Dec 2008 14:18:09 +0100

> 
> The netem simulator is no longer limited by Linux timer resolution HZ.
> Not since Patrick McHardy changed the QoS system to use hrtimer.
> 
> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>

Applied, thanks Jesper.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c
index a119599..98402f0 100644
--- a/net/sched/sch_netem.c
+++ b/net/sched/sch_netem.c
@@ -46,9 +46,6 @@ 
 	 layering other disciplines.  It does not need to do bandwidth
 	 control either since that can be handled by using token
 	 bucket or other rate control.
-
-	 The simulator is limited by the Linux timer resolution
-	 and will create packet bursts on the HZ boundary (1ms).
 */
 
 struct netem_sched_data {