Patchwork ext4: make local symbol ext4_initxattrs static

login
register
mail settings
Submitter Djalal Harouni
Date Jan. 4, 2012, 1:51 p.m.
Message ID <20120104135120.GA12859@dztty>
Download mbox | patch
Permalink /patch/134252/
State Accepted
Headers show

Comments

Djalal Harouni - Jan. 4, 2012, 1:51 p.m.
The ext4_initxattrs symbol is used only in this file, so it should be
declared static.

Signed-off-by: Djalal Harouni <tixxdz@opendz.org>
---
 fs/ext4/xattr_security.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Theodore Ts'o - Jan. 5, 2012, 3:34 a.m.
On Wed, Jan 04, 2012 at 02:51:20PM +0100, Djalal Harouni wrote:
> The ext4_initxattrs symbol is used only in this file, so it should be
> declared static.
> 
> Signed-off-by: Djalal Harouni <tixxdz@opendz.org>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/xattr_security.c b/fs/ext4/xattr_security.c
index 34e4350..e247f8b 100644
--- a/fs/ext4/xattr_security.c
+++ b/fs/ext4/xattr_security.c
@@ -48,8 +48,9 @@  ext4_xattr_security_set(struct dentry *dentry, const char *name,
 			      name, value, size, flags);
 }
 
-int ext4_initxattrs(struct inode *inode, const struct xattr *xattr_array,
-		    void *fs_info)
+static int
+ext4_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+		void *fs_info)
 {
 	const struct xattr *xattr;
 	handle_t *handle = fs_info;