Patchwork [U-Boot,v3,3/3] ARM:AM33XX: Add SPL support for AM335X EVM

login
register
mail settings
Submitter Chandan Nath
Date Jan. 3, 2012, 6:42 a.m.
Message ID <1325572976-25795-4-git-send-email-chandan.nath@ti.com>
Download mbox | patch
Permalink /patch/133981/
State Changes Requested
Delegated to: Tom Rini
Headers show

Comments

Chandan Nath - Jan. 3, 2012, 6:42 a.m.
This patch is added to support SPL feature on AM335X
platform. In this patch, MMC1 is configured as boot
device for SPL and support for other devices will be
added in the next patch series.

Signed-off-by: Chandan Nath <chandan.nath@ti.com>
Signed-off-by: Tom Rini <trini@ti.com>
---
Changes since v2:
 - Added missing omap.h file

Changes since v1:
 - Rebased to master branch
 - Replaced am33xx lowleve_init.S with omap-common lowlevel_init.S
   in order to use common code for omap_bootmode.

 arch/arm/cpu/armv7/am33xx/Makefile            |    2 -
 arch/arm/cpu/armv7/am33xx/board.c             |   65 +++++++++++++++++++++--
 arch/arm/cpu/armv7/am33xx/config.mk           |   18 ++++++
 arch/arm/cpu/armv7/am33xx/emif4.c             |    2 +-
 arch/arm/cpu/armv7/am33xx/lowlevel_init.S     |   72 -------------------------
 arch/arm/cpu/armv7/omap-common/Makefile       |    3 +
 arch/arm/include/asm/arch-am33xx/common_def.h |   22 ++++++++
 arch/arm/include/asm/arch-am33xx/omap.h       |   59 ++++++++++++++++++++
 arch/arm/include/asm/arch-am33xx/sys_proto.h  |    1 +
 arch/arm/include/asm/omap_common.h            |    5 ++
 board/ti/am335x/common_def.h                  |   24 --------
 board/ti/am335x/evm.c                         |    2 +-
 board/ti/am335x/mux.c                         |    2 +-
 include/configs/am335x_evm.h                  |   39 ++++++++++++-
 spl/Makefile                                  |   13 ++---
 15 files changed, 214 insertions(+), 115 deletions(-)
 create mode 100644 arch/arm/cpu/armv7/am33xx/config.mk
 delete mode 100644 arch/arm/cpu/armv7/am33xx/lowlevel_init.S
 create mode 100644 arch/arm/include/asm/arch-am33xx/common_def.h
 create mode 100644 arch/arm/include/asm/arch-am33xx/omap.h
 delete mode 100644 board/ti/am335x/common_def.h
Igor Grinberg - Jan. 3, 2012, 8:14 a.m.
On 01/03/12 08:42, Chandan Nath wrote:
> This patch is added to support SPL feature on AM335X
> platform. In this patch, MMC1 is configured as boot
> device for SPL and support for other devices will be
> added in the next patch series.
> 
> Signed-off-by: Chandan Nath <chandan.nath@ti.com>
> Signed-off-by: Tom Rini <trini@ti.com>
> ---
> Changes since v2:
>  - Added missing omap.h file
> 
> Changes since v1:
>  - Rebased to master branch
>  - Replaced am33xx lowleve_init.S with omap-common lowlevel_init.S
>    in order to use common code for omap_bootmode.
> 
>  arch/arm/cpu/armv7/am33xx/Makefile            |    2 -
>  arch/arm/cpu/armv7/am33xx/board.c             |   65 +++++++++++++++++++++--
>  arch/arm/cpu/armv7/am33xx/config.mk           |   18 ++++++
>  arch/arm/cpu/armv7/am33xx/emif4.c             |    2 +-
>  arch/arm/cpu/armv7/am33xx/lowlevel_init.S     |   72 -------------------------
>  arch/arm/cpu/armv7/omap-common/Makefile       |    3 +
>  arch/arm/include/asm/arch-am33xx/common_def.h |   22 ++++++++
>  arch/arm/include/asm/arch-am33xx/omap.h       |   59 ++++++++++++++++++++
>  arch/arm/include/asm/arch-am33xx/sys_proto.h  |    1 +
>  arch/arm/include/asm/omap_common.h            |    5 ++
>  board/ti/am335x/common_def.h                  |   24 --------
>  board/ti/am335x/evm.c                         |    2 +-
>  board/ti/am335x/mux.c                         |    2 +-
>  include/configs/am335x_evm.h                  |   39 ++++++++++++-
>  spl/Makefile                                  |   13 ++---
>  15 files changed, 214 insertions(+), 115 deletions(-)
>  create mode 100644 arch/arm/cpu/armv7/am33xx/config.mk
>  delete mode 100644 arch/arm/cpu/armv7/am33xx/lowlevel_init.S
>  create mode 100644 arch/arm/include/asm/arch-am33xx/common_def.h
>  create mode 100644 arch/arm/include/asm/arch-am33xx/omap.h
>  delete mode 100644 board/ti/am335x/common_def.h
> 
> diff --git a/arch/arm/cpu/armv7/am33xx/Makefile b/arch/arm/cpu/armv7/am33xx/Makefile
> index 6beafbb..7768912 100644
> --- a/arch/arm/cpu/armv7/am33xx/Makefile
> +++ b/arch/arm/cpu/armv7/am33xx/Makefile
> @@ -16,8 +16,6 @@ include $(TOPDIR)/config.mk
>  
>  LIB	= $(obj)lib$(SOC).o
>  
> -SOBJS	:= lowlevel_init.o
> -
>  COBJS	+= clock.o
>  COBJS	+= sys_info.o
>  COBJS	+= ddr.o
> diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c
> index 312643c..2a45933 100644
> --- a/arch/arm/cpu/armv7/am33xx/board.c
> +++ b/arch/arm/cpu/armv7/am33xx/board.c
> @@ -19,19 +19,45 @@
>  #include <common.h>
>  #include <asm/arch/cpu.h>
>  #include <asm/arch/hardware.h>
> +#include <asm/arch/omap.h>
>  #include <asm/arch/ddr_defs.h>
>  #include <asm/arch/clock.h>
> +#include <asm/arch/mmc_host_def.h>
> +#include <asm/arch/common_def.h>
>  #include <asm/io.h>
> +#include <asm/omap_common.h>
>  
>  DECLARE_GLOBAL_DATA_PTR;
>  
>  struct wd_timer *wdtimer = (struct wd_timer *)WDT_BASE;
>  struct gptimer *timer_base = (struct gptimer *)CONFIG_SYS_TIMERBASE;
> +struct uart_sys *uart_base = (struct uart_sys *)DEFAULT_UART_BASE;
> +
> +struct omap_boot_parameters boot_params __attribute__ ((section(".data")));
> +
> +#ifdef CONFIG_SPL_BUILD
> +u32 omap_bootmode = MMCSD_MODE_FAT;
> +
> +u32 omap_boot_device(void)
> +{
> +	return (u32) (boot_params.omap_bootdevice);
> +}
> +
> +u32 omap_boot_mode(void)
> +{
> +	return omap_bootmode;
> +}
> +

can't arch/arm/cpu/armv7/omap-common/hwinit-common.c be used for this?

[...]
Chandan Nath - Jan. 3, 2012, 8:18 a.m.
> -----Original Message-----
> From: Igor Grinberg [mailto:grinberg@compulab.co.il]
> Sent: Tuesday, January 03, 2012 1:44 PM
> To: Kumar Nath, Chandan
> Cc: u-boot@lists.denx.de; Rini, Tom
> Subject: Re: [U-Boot] [PATCH v3 3/3] ARM:AM33XX: Add SPL support for
> AM335X EVM
> 
> On 01/03/12 08:42, Chandan Nath wrote:
> > This patch is added to support SPL feature on AM335X
> > platform. In this patch, MMC1 is configured as boot
> > device for SPL and support for other devices will be
> > added in the next patch series.
> >
> > Signed-off-by: Chandan Nath <chandan.nath@ti.com>
> > Signed-off-by: Tom Rini <trini@ti.com>
> > ---
> > Changes since v2:
> >  - Added missing omap.h file
> >
> > Changes since v1:
> >  - Rebased to master branch
> >  - Replaced am33xx lowleve_init.S with omap-common lowlevel_init.S
> >    in order to use common code for omap_bootmode.
> >
> >  arch/arm/cpu/armv7/am33xx/Makefile            |    2 -
> >  arch/arm/cpu/armv7/am33xx/board.c             |   65
> +++++++++++++++++++++--
> >  arch/arm/cpu/armv7/am33xx/config.mk           |   18 ++++++
> >  arch/arm/cpu/armv7/am33xx/emif4.c             |    2 +-
> >  arch/arm/cpu/armv7/am33xx/lowlevel_init.S     |   72 ---------------
> ----------
> >  arch/arm/cpu/armv7/omap-common/Makefile       |    3 +
> >  arch/arm/include/asm/arch-am33xx/common_def.h |   22 ++++++++
> >  arch/arm/include/asm/arch-am33xx/omap.h       |   59
> ++++++++++++++++++++
> >  arch/arm/include/asm/arch-am33xx/sys_proto.h  |    1 +
> >  arch/arm/include/asm/omap_common.h            |    5 ++
> >  board/ti/am335x/common_def.h                  |   24 --------
> >  board/ti/am335x/evm.c                         |    2 +-
> >  board/ti/am335x/mux.c                         |    2 +-
> >  include/configs/am335x_evm.h                  |   39 ++++++++++++-
> >  spl/Makefile                                  |   13 ++---
> >  15 files changed, 214 insertions(+), 115 deletions(-)
> >  create mode 100644 arch/arm/cpu/armv7/am33xx/config.mk
> >  delete mode 100644 arch/arm/cpu/armv7/am33xx/lowlevel_init.S
> >  create mode 100644 arch/arm/include/asm/arch-am33xx/common_def.h
> >  create mode 100644 arch/arm/include/asm/arch-am33xx/omap.h
> >  delete mode 100644 board/ti/am335x/common_def.h
> >
> > diff --git a/arch/arm/cpu/armv7/am33xx/Makefile
> b/arch/arm/cpu/armv7/am33xx/Makefile
> > index 6beafbb..7768912 100644
> > --- a/arch/arm/cpu/armv7/am33xx/Makefile
> > +++ b/arch/arm/cpu/armv7/am33xx/Makefile
> > @@ -16,8 +16,6 @@ include $(TOPDIR)/config.mk
> >
> >  LIB	= $(obj)lib$(SOC).o
> >
> > -SOBJS	:= lowlevel_init.o
> > -
> >  COBJS	+= clock.o
> >  COBJS	+= sys_info.o
> >  COBJS	+= ddr.o
> > diff --git a/arch/arm/cpu/armv7/am33xx/board.c
> b/arch/arm/cpu/armv7/am33xx/board.c
> > index 312643c..2a45933 100644
> > --- a/arch/arm/cpu/armv7/am33xx/board.c
> > +++ b/arch/arm/cpu/armv7/am33xx/board.c
> > @@ -19,19 +19,45 @@
> >  #include <common.h>
> >  #include <asm/arch/cpu.h>
> >  #include <asm/arch/hardware.h>
> > +#include <asm/arch/omap.h>
> >  #include <asm/arch/ddr_defs.h>
> >  #include <asm/arch/clock.h>
> > +#include <asm/arch/mmc_host_def.h>
> > +#include <asm/arch/common_def.h>
> >  #include <asm/io.h>
> > +#include <asm/omap_common.h>
> >
> >  DECLARE_GLOBAL_DATA_PTR;
> >
> >  struct wd_timer *wdtimer = (struct wd_timer *)WDT_BASE;
> >  struct gptimer *timer_base = (struct gptimer *)CONFIG_SYS_TIMERBASE;
> > +struct uart_sys *uart_base = (struct uart_sys *)DEFAULT_UART_BASE;
> > +
> > +struct omap_boot_parameters boot_params __attribute__
> ((section(".data")));
> > +
> > +#ifdef CONFIG_SPL_BUILD
> > +u32 omap_bootmode = MMCSD_MODE_FAT;
> > +
> > +u32 omap_boot_device(void)
> > +{
> > +	return (u32) (boot_params.omap_bootdevice);
> > +}
> > +
> > +u32 omap_boot_mode(void)
> > +{
> > +	return omap_bootmode;
> > +}
> > +
> 
> can't arch/arm/cpu/armv7/omap-common/hwinit-common.c be used for this?

I tried using hwinit-common.c file, but there are some other functions defined
which are not required. Could you tell me if there is any method to use only
Above functions from hwinit-common.c file.

> 
> [...]
> 
> 
> --
> Regards,
> Igor.
Igor Grinberg - Jan. 3, 2012, 8:34 a.m.
Hi Chandan,

On 01/03/12 10:18, Kumar Nath, Chandan wrote:
> 
>> On 01/03/12 08:42, Chandan Nath wrote:
>>> This patch is added to support SPL feature on AM335X
>>> platform. In this patch, MMC1 is configured as boot
>>> device for SPL and support for other devices will be
>>> added in the next patch series.
>>>
>>> Signed-off-by: Chandan Nath <chandan.nath@ti.com>
>>> Signed-off-by: Tom Rini <trini@ti.com>
>>> ---
>>> Changes since v2:
>>>  - Added missing omap.h file
>>>
>>> Changes since v1:
>>>  - Rebased to master branch
>>>  - Replaced am33xx lowleve_init.S with omap-common lowlevel_init.S
>>>    in order to use common code for omap_bootmode.

[...]

>>> diff --git a/arch/arm/cpu/armv7/am33xx/board.c
>> b/arch/arm/cpu/armv7/am33xx/board.c
>>> index 312643c..2a45933 100644
>>> --- a/arch/arm/cpu/armv7/am33xx/board.c
>>> +++ b/arch/arm/cpu/armv7/am33xx/board.c
>>> @@ -19,19 +19,45 @@
>>>  #include <common.h>
>>>  #include <asm/arch/cpu.h>
>>>  #include <asm/arch/hardware.h>
>>> +#include <asm/arch/omap.h>
>>>  #include <asm/arch/ddr_defs.h>
>>>  #include <asm/arch/clock.h>
>>> +#include <asm/arch/mmc_host_def.h>
>>> +#include <asm/arch/common_def.h>
>>>  #include <asm/io.h>
>>> +#include <asm/omap_common.h>
>>>
>>>  DECLARE_GLOBAL_DATA_PTR;
>>>
>>>  struct wd_timer *wdtimer = (struct wd_timer *)WDT_BASE;
>>>  struct gptimer *timer_base = (struct gptimer *)CONFIG_SYS_TIMERBASE;
>>> +struct uart_sys *uart_base = (struct uart_sys *)DEFAULT_UART_BASE;
>>> +
>>> +struct omap_boot_parameters boot_params __attribute__
>> ((section(".data")));
>>> +
>>> +#ifdef CONFIG_SPL_BUILD
>>> +u32 omap_bootmode = MMCSD_MODE_FAT;
>>> +
>>> +u32 omap_boot_device(void)
>>> +{
>>> +	return (u32) (boot_params.omap_bootdevice);
>>> +}
>>> +
>>> +u32 omap_boot_mode(void)
>>> +{
>>> +	return omap_bootmode;
>>> +}
>>> +
>>
>> can't arch/arm/cpu/armv7/omap-common/hwinit-common.c be used for this?
> 
> I tried using hwinit-common.c file, but there are some other functions defined
> which are not required. Could you tell me if there is any method to use only
> Above functions from hwinit-common.c file.

At least two ways, I can think of:
The less pretty, is introduce ifdefs in that file.
Another and IMO better option is split the file into
common and "less" common content and then reuse the right one.
With the later, you prevent the needless ifdeffery, but need to
be careful not to break any existing platforms.
Wolfgang Denk - Jan. 3, 2012, 9:03 a.m.
Dear "Kumar Nath, Chandan",

In message <1FEB0F76D6F5E244AC1DAE6C32484BBD034428@DBDE01.ent.ti.com> you wrote:
> 
> > can't arch/arm/cpu/armv7/omap-common/hwinit-common.c be used for this?
> 
> I tried using hwinit-common.c file, but there are some other functions defined
> which are not required. Could you tell me if there is any method to use only
> Above functions from hwinit-common.c file.

Does not -ffunction-sections in combination with -gc-sections take
care of that?

Best regards,

Wolfgang Denk
Tom Rini - Jan. 3, 2012, 2:24 p.m.
On 01/03/2012 01:18 AM, Kumar Nath, Chandan wrote:
> 
>> -----Original Message-----
>> From: Igor Grinberg [mailto:grinberg@compulab.co.il]
>> Sent: Tuesday, January 03, 2012 1:44 PM
>> To: Kumar Nath, Chandan
>> Cc: u-boot@lists.denx.de; Rini, Tom
>> Subject: Re: [U-Boot] [PATCH v3 3/3] ARM:AM33XX: Add SPL support for
>> AM335X EVM
>>
>> On 01/03/12 08:42, Chandan Nath wrote:
>>> This patch is added to support SPL feature on AM335X
>>> platform. In this patch, MMC1 is configured as boot
>>> device for SPL and support for other devices will be
>>> added in the next patch series.
>>>
>>> Signed-off-by: Chandan Nath <chandan.nath@ti.com>
>>> Signed-off-by: Tom Rini <trini@ti.com>
>>> ---
>>> Changes since v2:
>>>  - Added missing omap.h file
>>>
>>> Changes since v1:
>>>  - Rebased to master branch
>>>  - Replaced am33xx lowleve_init.S with omap-common lowlevel_init.S
>>>    in order to use common code for omap_bootmode.
>>>
>>>  arch/arm/cpu/armv7/am33xx/Makefile            |    2 -
>>>  arch/arm/cpu/armv7/am33xx/board.c             |   65
>> +++++++++++++++++++++--
>>>  arch/arm/cpu/armv7/am33xx/config.mk           |   18 ++++++
>>>  arch/arm/cpu/armv7/am33xx/emif4.c             |    2 +-
>>>  arch/arm/cpu/armv7/am33xx/lowlevel_init.S     |   72 ---------------
>> ----------
>>>  arch/arm/cpu/armv7/omap-common/Makefile       |    3 +
>>>  arch/arm/include/asm/arch-am33xx/common_def.h |   22 ++++++++
>>>  arch/arm/include/asm/arch-am33xx/omap.h       |   59
>> ++++++++++++++++++++
>>>  arch/arm/include/asm/arch-am33xx/sys_proto.h  |    1 +
>>>  arch/arm/include/asm/omap_common.h            |    5 ++
>>>  board/ti/am335x/common_def.h                  |   24 --------
>>>  board/ti/am335x/evm.c                         |    2 +-
>>>  board/ti/am335x/mux.c                         |    2 +-
>>>  include/configs/am335x_evm.h                  |   39 ++++++++++++-
>>>  spl/Makefile                                  |   13 ++---
>>>  15 files changed, 214 insertions(+), 115 deletions(-)
>>>  create mode 100644 arch/arm/cpu/armv7/am33xx/config.mk
>>>  delete mode 100644 arch/arm/cpu/armv7/am33xx/lowlevel_init.S
>>>  create mode 100644 arch/arm/include/asm/arch-am33xx/common_def.h
>>>  create mode 100644 arch/arm/include/asm/arch-am33xx/omap.h
>>>  delete mode 100644 board/ti/am335x/common_def.h
>>>
>>> diff --git a/arch/arm/cpu/armv7/am33xx/Makefile
>> b/arch/arm/cpu/armv7/am33xx/Makefile
>>> index 6beafbb..7768912 100644
>>> --- a/arch/arm/cpu/armv7/am33xx/Makefile
>>> +++ b/arch/arm/cpu/armv7/am33xx/Makefile
>>> @@ -16,8 +16,6 @@ include $(TOPDIR)/config.mk
>>>
>>>  LIB	= $(obj)lib$(SOC).o
>>>
>>> -SOBJS	:= lowlevel_init.o
>>> -
>>>  COBJS	+= clock.o
>>>  COBJS	+= sys_info.o
>>>  COBJS	+= ddr.o
>>> diff --git a/arch/arm/cpu/armv7/am33xx/board.c
>> b/arch/arm/cpu/armv7/am33xx/board.c
>>> index 312643c..2a45933 100644
>>> --- a/arch/arm/cpu/armv7/am33xx/board.c
>>> +++ b/arch/arm/cpu/armv7/am33xx/board.c
>>> @@ -19,19 +19,45 @@
>>>  #include <common.h>
>>>  #include <asm/arch/cpu.h>
>>>  #include <asm/arch/hardware.h>
>>> +#include <asm/arch/omap.h>
>>>  #include <asm/arch/ddr_defs.h>
>>>  #include <asm/arch/clock.h>
>>> +#include <asm/arch/mmc_host_def.h>
>>> +#include <asm/arch/common_def.h>
>>>  #include <asm/io.h>
>>> +#include <asm/omap_common.h>
>>>
>>>  DECLARE_GLOBAL_DATA_PTR;
>>>
>>>  struct wd_timer *wdtimer = (struct wd_timer *)WDT_BASE;
>>>  struct gptimer *timer_base = (struct gptimer *)CONFIG_SYS_TIMERBASE;
>>> +struct uart_sys *uart_base = (struct uart_sys *)DEFAULT_UART_BASE;
>>> +
>>> +struct omap_boot_parameters boot_params __attribute__
>> ((section(".data")));
>>> +
>>> +#ifdef CONFIG_SPL_BUILD
>>> +u32 omap_bootmode = MMCSD_MODE_FAT;
>>> +
>>> +u32 omap_boot_device(void)
>>> +{
>>> +	return (u32) (boot_params.omap_bootdevice);
>>> +}
>>> +
>>> +u32 omap_boot_mode(void)
>>> +{
>>> +	return omap_bootmode;
>>> +}
>>> +
>>
>> can't arch/arm/cpu/armv7/omap-common/hwinit-common.c be used for this?
> 
> I tried using hwinit-common.c file, but there are some other functions defined
> which are not required. Could you tell me if there is any method to use only
> Above functions from hwinit-common.c file.

This probably just means there's further common code that am33xx needs
to be moved over to use from the omap4/5 family.  For example, the emif
code.

Patch

diff --git a/arch/arm/cpu/armv7/am33xx/Makefile b/arch/arm/cpu/armv7/am33xx/Makefile
index 6beafbb..7768912 100644
--- a/arch/arm/cpu/armv7/am33xx/Makefile
+++ b/arch/arm/cpu/armv7/am33xx/Makefile
@@ -16,8 +16,6 @@  include $(TOPDIR)/config.mk
 
 LIB	= $(obj)lib$(SOC).o
 
-SOBJS	:= lowlevel_init.o
-
 COBJS	+= clock.o
 COBJS	+= sys_info.o
 COBJS	+= ddr.o
diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c
index 312643c..2a45933 100644
--- a/arch/arm/cpu/armv7/am33xx/board.c
+++ b/arch/arm/cpu/armv7/am33xx/board.c
@@ -19,19 +19,45 @@ 
 #include <common.h>
 #include <asm/arch/cpu.h>
 #include <asm/arch/hardware.h>
+#include <asm/arch/omap.h>
 #include <asm/arch/ddr_defs.h>
 #include <asm/arch/clock.h>
+#include <asm/arch/mmc_host_def.h>
+#include <asm/arch/common_def.h>
 #include <asm/io.h>
+#include <asm/omap_common.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
 struct wd_timer *wdtimer = (struct wd_timer *)WDT_BASE;
 struct gptimer *timer_base = (struct gptimer *)CONFIG_SYS_TIMERBASE;
+struct uart_sys *uart_base = (struct uart_sys *)DEFAULT_UART_BASE;
+
+struct omap_boot_parameters boot_params __attribute__ ((section(".data")));
+
+#ifdef CONFIG_SPL_BUILD
+u32 omap_bootmode = MMCSD_MODE_FAT;
+
+u32 omap_boot_device(void)
+{
+	return (u32) (boot_params.omap_bootdevice);
+}
+
+u32 omap_boot_mode(void)
+{
+	return omap_bootmode;
+}
+
+/* UART Defines */
+#define UART_RESET		(0x1 << 1)
+#define UART_CLK_RUNNING_MASK	0x1
+#define UART_SMART_IDLE_EN	(0x1 << 0x3)
+#endif
 
 /*
  * early system init of muxing and clocks.
  */
-void s_init(u32 in_ddr)
+void s_init(void)
 {
 	/* WDT1 is already running when the bootloader gets control
 	 * Disable it to avoid "random" resets
@@ -43,12 +69,37 @@  void s_init(u32 in_ddr)
 	while (readl(&wdtimer->wdtwwps) != 0x0)
 		;
 
+#ifdef CONFIG_SPL_BUILD
 	/* Setup the PLLs and the clocks for the peripherals */
-#ifdef CONFIG_SETUP_PLL
 	pll_init();
+
+	/* UART softreset */
+	u32 regVal;
+
+	enable_uart0_pin_mux();
+
+	regVal = readl(&uart_base->uartsyscfg);
+	regVal |= UART_RESET;
+	writel(regVal, &uart_base->uartsyscfg);
+	while ((readl(&uart_base->uartsyssts) &
+		UART_CLK_RUNNING_MASK) != UART_CLK_RUNNING_MASK)
+		;
+
+	/* Disable smart idle */
+	regVal = readl(&uart_base->uartsyscfg);
+	regVal |= UART_SMART_IDLE_EN;
+	writel(regVal, &uart_base->uartsyscfg);
+
+	/* Initialize the Timer */
+	init_timer();
+
+	preloader_console_init();
+
+	config_ddr();
 #endif
-	if (!in_ddr)
-		config_ddr();
+
+	/* Enable MMC0 */
+	enable_mmc0_pin_mux();
 }
 
 /* Initialize timer */
@@ -71,3 +122,9 @@  int board_mmc_init(bd_t *bis)
 	return omap_mmc_init(0);
 }
 #endif
+
+void setup_clocks_for_console(void)
+{
+	/* Not yet implemented */
+	return;
+}
diff --git a/arch/arm/cpu/armv7/am33xx/config.mk b/arch/arm/cpu/armv7/am33xx/config.mk
new file mode 100644
index 0000000..5750bbd
--- /dev/null
+++ b/arch/arm/cpu/armv7/am33xx/config.mk
@@ -0,0 +1,18 @@ 
+#
+# Copyright (C) 2011, Texas Instruments, Incorporated - http://www.ti.com/
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed "as is" WITHOUT ANY WARRANTY of any
+# kind, whether express or implied; without even the implied warranty
+# of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+ifdef CONFIG_SPL_BUILD
+ALL-y	+= $(OBJTREE)/MLO
+else
+ALL-y	+= $(obj)u-boot.img
+endif
diff --git a/arch/arm/cpu/armv7/am33xx/emif4.c b/arch/arm/cpu/armv7/am33xx/emif4.c
index 1318365..2f4164d 100644
--- a/arch/arm/cpu/armv7/am33xx/emif4.c
+++ b/arch/arm/cpu/armv7/am33xx/emif4.c
@@ -46,7 +46,7 @@  void dram_init_banksize(void)
 }
 
 
-#ifdef CONFIG_AM335X_CONFIG_DDR
+#ifdef CONFIG_SPL_BUILD
 static void data_macro_config(int dataMacroNum)
 {
 	struct ddr_data data;
diff --git a/arch/arm/cpu/armv7/am33xx/lowlevel_init.S b/arch/arm/cpu/armv7/am33xx/lowlevel_init.S
deleted file mode 100644
index 17c962f..0000000
--- a/arch/arm/cpu/armv7/am33xx/lowlevel_init.S
+++ /dev/null
@@ -1,72 +0,0 @@ 
-/*
- * lowlevel_init.S
- *
- * AM33XX low level initialization.
- *
- * Copyright (C) 2011, Texas Instruments, Incorporated - http://www.ti.com/
- *
- * Initial Code by:
- * Mansoor Ahamed  <mansoor.ahamed@ti.com>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed "as is" WITHOUT ANY WARRANTY of any
- * kind, whether express or implied; without even the implied warranty
- * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-#include <config.h>
-#include <asm/arch/hardware.h>
-
-_mark1:
-	.word mark1
-_lowlevel_init1:
-	.word lowlevel_init
-_s_init_start:
-	.word s_init_start
-
-_TEXT_BASE:
-	.word	CONFIG_SYS_TEXT_BASE	/* sdram load addr from config.mk */
-
-/*****************************************************************************
- * lowlevel_init: - Platform low level init.
- ****************************************************************************/
-.globl lowlevel_init
-lowlevel_init:
-
-	/* The link register is saved in ip by start.S */
-	mov r6, ip
-	/* check if we are already running from RAM */
-	ldr r2, _lowlevel_init1
-	ldr r3, _TEXT_BASE
-	sub r4, r2, r3
-	sub r0, pc, r4
-	ldr sp, SRAM_STACK
-mark1:
-	ldr r5, _mark1
-	sub r5, r5, r2 /* bytes between mark1 and lowlevel_init */
-	sub r0, r0, r5 /* r0 <- _start w.r.t current place of execution */
-	mov r10, #0x0 /* r10 has in_ddr used by s_init() */
-
-	ands r0, r0, #0xC0000000
-	/* MSB 2 bits <> 0 then we are in ocmc or DDR */
-	cmp r0, #0x80000000
-	bne s_init_start
-	mov r10, #0x01
-	b s_init_start
-
-s_init_start:
-	mov r0, r10 /* passing in_ddr in r0 */
-	bl s_init
-	/* back to arch calling code */
-	mov pc, r6
-	/* the literal pools origin */
-	.ltorg
-
-SRAM_STACK:
-	/* Place stack at the top */
-	.word LOW_LEVEL_SRAM_STACK
diff --git a/arch/arm/cpu/armv7/omap-common/Makefile b/arch/arm/cpu/armv7/omap-common/Makefile
index a684611..517f7b1 100644
--- a/arch/arm/cpu/armv7/omap-common/Makefile
+++ b/arch/arm/cpu/armv7/omap-common/Makefile
@@ -37,6 +37,9 @@  ifneq ($(CONFIG_OMAP44XX)$(CONFIG_OMAP54XX),)
 COBJS	+= hwinit-common.o
 COBJS	+= clocks-common.o
 COBJS	+= emif-common.o
+endif
+
+ifneq ($(CONFIG_AM33XX)$(CONFIG_OMAP44XX)$(CONFIG_OMAP54XX),)
 SOBJS	+= lowlevel_init.o
 endif
 
diff --git a/arch/arm/include/asm/arch-am33xx/common_def.h b/arch/arm/include/asm/arch-am33xx/common_def.h
new file mode 100644
index 0000000..767932d
--- /dev/null
+++ b/arch/arm/include/asm/arch-am33xx/common_def.h
@@ -0,0 +1,22 @@ 
+/*
+ * common_def.h
+ *
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation version 2.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether express or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __COMMON_DEF_H__
+#define __COMMON_DEF_H__
+
+extern void enable_uart0_pin_mux(void);
+extern void enable_mmc0_pin_mux(void);
+
+#endif/*__COMMON_DEF_H__ */
diff --git a/arch/arm/include/asm/arch-am33xx/omap.h b/arch/arm/include/asm/arch-am33xx/omap.h
new file mode 100644
index 0000000..fc2b7a5
--- /dev/null
+++ b/arch/arm/include/asm/arch-am33xx/omap.h
@@ -0,0 +1,59 @@ 
+/*
+ * omap.h
+ *
+ * Copyright (C) 2011, Texas Instruments, Incorporated - http://www.ti.com/
+ *
+ * Author:
+ *	Chandan Nath <chandan.nath@ti.com>
+ *
+ * Derived from OMAP4 work by
+ *	Aneesh V <aneesh@ti.com>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR /PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef _OMAP_H_
+#define _OMAP_H_
+
+/*
+ * Non-secure SRAM Addresses
+ * Non-secure RAM starts at 0x40300000 for GP devices. But we keep SRAM_BASE
+ * at 0x40304000(EMU base) so that our code works for both EMU and GP
+ */
+#define NON_SECURE_SRAM_START	0x40304000
+#define NON_SECURE_SRAM_END	0x4030E000
+#define LOW_LEVEL_SRAM_STACK	0x4030B7FC
+
+/* ROM code defines */
+/* Boot device */
+#define BOOT_DEVICE_MASK	0xFF
+#define BOOT_DEVICE_OFFSET	0x8
+#define DEV_DESC_PTR_OFFSET	0x4
+#define DEV_DATA_PTR_OFFSET	0x18
+#define BOOT_MODE_OFFSET	0x8
+#define RESET_REASON_OFFSET	0x9
+#define CH_FLAGS_OFFSET		0xA
+
+#define CH_FLAGS_CHSETTINGS	(0x1 << 0)
+#define CH_FLAGS_CHRAM		(0x1 << 1)
+#define CH_FLAGS_CHFLASH	(0x1 << 2)
+#define CH_FLAGS_CHMMCSD	(0x1 << 3)
+
+#ifndef __ASSEMBLY__
+struct omap_boot_parameters {
+	char *boot_message;
+	unsigned int mem_boot_descriptor;
+	unsigned char omap_bootdevice;
+	unsigned char reset_reason;
+	unsigned char ch_flags;
+};
+#endif
+#endif
diff --git a/arch/arm/include/asm/arch-am33xx/sys_proto.h b/arch/arm/include/asm/arch-am33xx/sys_proto.h
index 09ed650..6c58f1b 100644
--- a/arch/arm/include/asm/arch-am33xx/sys_proto.h
+++ b/arch/arm/include/asm/arch-am33xx/sys_proto.h
@@ -29,4 +29,5 @@  int print_cpuinfo(void);
 #endif
 
 u32 get_device_type(void);
+void setup_clocks_for_console(void);
 #endif
diff --git a/arch/arm/include/asm/omap_common.h b/arch/arm/include/asm/omap_common.h
index 1ec651b..6b4c010 100644
--- a/arch/arm/include/asm/omap_common.h
+++ b/arch/arm/include/asm/omap_common.h
@@ -62,6 +62,11 @@  void preloader_console_init(void);
 #define BOOT_DEVICE_MMC2	5 /*emmc*/
 #define BOOT_DEVICE_MMC1	6
 #define BOOT_DEVICE_XIPWAIT	7
+#elif defined(CONFIG_AM33XX)	/* AM33XX */
+#define BOOT_DEVICE_NAND	5
+#define BOOT_DEVICE_MMC1	8
+#define BOOT_DEVICE_MMC2	0 /* eMMC, TODO */
+#define BOOT_DEVICE_UART	65
 #endif
 
 /* Boot type */
diff --git a/board/ti/am335x/common_def.h b/board/ti/am335x/common_def.h
deleted file mode 100644
index 1696d60..0000000
--- a/board/ti/am335x/common_def.h
+++ /dev/null
@@ -1,24 +0,0 @@ 
-/*
- * common_def.h
- *
- * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation version 2.
- *
- * This program is distributed "as is" WITHOUT ANY WARRANTY of any
- * kind, whether express or implied; without even the implied warranty
- * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-#ifndef __COMMON_DEF_H__
-#define __COMMON_DEF_H__
-
-extern void enable_uart0_pin_mux(void);
-extern void configure_evm_pin_mux(unsigned char daughter_board_id,
-					unsigned short daughter_board_profile,
-					unsigned char daughter_board_flag);
-
-#endif/*__COMMON_DEF_H__ */
diff --git a/board/ti/am335x/evm.c b/board/ti/am335x/evm.c
index b4eddd8..6a9f788 100644
--- a/board/ti/am335x/evm.c
+++ b/board/ti/am335x/evm.c
@@ -16,7 +16,7 @@ 
 #include <common.h>
 #include <asm/arch/cpu.h>
 #include <asm/arch/hardware.h>
-#include "common_def.h"
+#include <asm/arch/common_def.h>
 #include <serial.h>
 
 DECLARE_GLOBAL_DATA_PTR;
diff --git a/board/ti/am335x/mux.c b/board/ti/am335x/mux.c
index df11752..c2a61bd 100644
--- a/board/ti/am335x/mux.c
+++ b/board/ti/am335x/mux.c
@@ -14,7 +14,7 @@ 
  */
 
 #include <config.h>
-#include "common_def.h"
+#include <asm/arch/common_def.h>
 #include <asm/arch/hardware.h>
 #include <asm/io.h>
 
diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
index bd68e9a..049347c 100644
--- a/include/configs/am335x_evm.h
+++ b/include/configs/am335x_evm.h
@@ -26,8 +26,6 @@ 
 #include <asm/arch/cpu.h>
 #include <asm/arch/hardware.h>
 
-#define CONFIG_SETUP_PLL
-#define CONFIG_AM335X_CONFIG_DDR
 #define CONFIG_ENV_SIZE			0x400
 #define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (8 * 1024))
 #define CONFIG_SYS_PROMPT		"U-Boot# "
@@ -119,7 +117,42 @@ 
 
 #define CONFIG_ENV_IS_NOWHERE
 
-#define CONFIG_SYS_TEXT_BASE		0x402f0400
+/* Defines for SPL */
+#define CONFIG_SPL
+#define CONFIG_SPL_TEXT_BASE		0x402F0400
+#define CONFIG_SPL_MAX_SIZE		(46 * 1024)
+#define CONFIG_SPL_STACK		LOW_LEVEL_SRAM_STACK
+
+#define CONFIG_SPL_BSS_START_ADDR	0x80000000
+#define CONFIG_SPL_BSS_MAX_SIZE		0x80000		/* 512 KB */
+
+#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR	0x300 /* address 0x60000 */
+#define CONFIG_SYS_U_BOOT_MAX_SIZE_SECTORS	0x200 /* 256 KB */
+#define CONFIG_SYS_MMC_SD_FAT_BOOT_PARTITION	1
+#define CONFIG_SPL_FAT_LOAD_PAYLOAD_NAME	"u-boot.img"
+#define CONFIG_SPL_MMC_SUPPORT
+#define CONFIG_SPL_FAT_SUPPORT
+
+#define CONFIG_SPL_LIBCOMMON_SUPPORT
+#define CONFIG_SPL_LIBDISK_SUPPORT
+#define CONFIG_SPL_LIBGENERIC_SUPPORT
+#define CONFIG_SPL_SERIAL_SUPPORT
+#define CONFIG_SPL_LDSCRIPT		"$(CPUDIR)/omap-common/u-boot-spl.lds"
+
+/*
+ * 1MB into the SDRAM to allow for SPL's bss at the beginning of SDRAM
+ * 64 bytes before this address should be set aside for u-boot.img's
+ * header. That is 0x800FFFC0--0x80100000 should not be used for any
+ * other needs.
+ */
+#define CONFIG_SYS_TEXT_BASE		0x80800000
+#define CONFIG_SYS_SPL_MALLOC_START	0x80208000
+#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000
+
+/* Since SPL did all of this for us, we don't need to do it twice. */
+#ifndef CONFIG_SPL_BUILD
+#define CONFIG_SKIP_LOWLEVEL_INIT
+#endif
 
 /* Unsupported features */
 #undef CONFIG_USE_IRQ
diff --git a/spl/Makefile b/spl/Makefile
index 6ac42a2..3262e22 100644
--- a/spl/Makefile
+++ b/spl/Makefile
@@ -58,13 +58,7 @@  LIBS-$(CONFIG_SPL_ONENAND_SUPPORT) += drivers/mtd/onenand/libonenand.o
 LIBS-$(CONFIG_SPL_DMA_SUPPORT) += drivers/dma/libdma.o
 LIBS-$(CONFIG_SPL_POST_MEM_SUPPORT) += post/drivers/memory.o
 
-ifeq ($(SOC),omap3)
-LIBS-y += $(CPUDIR)/omap-common/libomap-common.o
-endif
-ifeq ($(SOC),omap4)
-LIBS-y += $(CPUDIR)/omap-common/libomap-common.o
-endif
-ifeq ($(SOC),omap5)
+ifneq ($(CONFIG_AM33XX)$(CONFIG_OMAP34XX)$(CONFIG_OMAP44XX)$(CONFIG_OMAP54XX),)
 LIBS-y += $(CPUDIR)/omap-common/libomap-common.o
 endif
 
@@ -104,6 +98,11 @@  $(OBJTREE)/MLO:	$(obj)u-boot-spl.bin
 	$(OBJTREE)/tools/mkimage -T omapimage \
 		-a $(CONFIG_SPL_TEXT_BASE) -d $< $@
 endif
+ifdef CONFIG_AM33XX
+$(OBJTREE)/MLO:	$(obj)u-boot-spl.bin
+	$(OBJTREE)/tools/mkimage -T omapimage \
+		-a $(CONFIG_SPL_TEXT_BASE) -d $< $@
+endif
 
 ALL-y	+= $(obj)u-boot-spl.bin