Patchwork [ANNOUNCE] libnetfilter_queue 1.0.1 release

login
register
mail settings
Submitter Jan Engelhardt
Date Jan. 2, 2012, 9:22 p.m.
Message ID <alpine.LNX.2.01.1201022221470.29809@frira.zrqbmnf.qr>
Download mbox | patch
Permalink /patch/133918/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Jan Engelhardt - Jan. 2, 2012, 9:22 p.m.
On Monday 2012-01-02 20:58, Pablo Neira Ayuso wrote:

>Hi!
>
>The Netfilter project proudly presents:
>
>        libnetfilter_queue 1.0.1

In commit 390b0c0f45597c72fa93a40f4f7f9ffeec371f42
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date:   Mon Jan 2 20:28:45 2012 +0100

    build: bump version to 1.0.1
    
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>


You wrongly changed LIBVERSION. It went from .so.1.1 to so.0.2, and that 
just does not sound right. Perhaps you intended 2:1:1.

Or just leaving r alone, like proposed? :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pablo Neira - Jan. 2, 2012, 9:45 p.m.
On Mon, Jan 02, 2012 at 10:22:28PM +0100, Jan Engelhardt wrote:
> On Monday 2012-01-02 20:58, Pablo Neira Ayuso wrote:
> 
> >Hi!
> >
> >The Netfilter project proudly presents:
> >
> >        libnetfilter_queue 1.0.1
> 
> In commit 390b0c0f45597c72fa93a40f4f7f9ffeec371f42
> Author: Pablo Neira Ayuso <pablo@netfilter.org>
> Date:   Mon Jan 2 20:28:45 2012 +0100
> 
>     build: bump version to 1.0.1
>     
>     Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 0bd037f..bc27625 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -18,7 +18,7 @@
>  # set age to 0.
>  # </snippet>
>  #
> -LIBVERSION=2:0:1
> +LIBVERSION=2:0:2
>  
>  include ${top_srcdir}/Make_global.am
>  
> 
> You wrongly changed LIBVERSION. It went from .so.1.1 to so.0.2, and that 
> just does not sound right. Perhaps you intended 2:1:1.
> 
> Or just leaving r alone, like proposed? :)

I forgot to increment current, Florian Westphal added some new
interfaces. I'll fix this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/src/Makefile.am b/src/Makefile.am
index 0bd037f..bc27625 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -18,7 +18,7 @@ 
 # set age to 0.
 # </snippet>
 #
-LIBVERSION=2:0:1
+LIBVERSION=2:0:2
 
 include ${top_srcdir}/Make_global.am