| Message ID | 1325477374-6417-15-git-send-email-graeme.russ@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Graeme, On Sun, Jan 1, 2012 at 8:09 PM, Graeme Russ <graeme.russ@gmail.com> wrote: > > Signed-off-by: Graeme Russ <graeme.russ@gmail.com> Perhaps mention why? Anyway: Acked-by: Simon Glass <sjg@chromium.org> Regards, Simon > --- > arch/x86/lib/board.c | 7 ------- > arch/x86/lib/zimage.c | 7 +++++++ > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/x86/lib/board.c b/arch/x86/lib/board.c > index 533adf1..993e7df 100644 > --- a/arch/x86/lib/board.c > +++ b/arch/x86/lib/board.c > @@ -486,10 +486,3 @@ void hang(void) > for (;;) > ; > } > - > -void setup_pcat_compatibility(void) > - __attribute__((weak, alias("__setup_pcat_compatibility"))); > - > -void __setup_pcat_compatibility(void) > -{ > -} > diff --git a/arch/x86/lib/zimage.c b/arch/x86/lib/zimage.c > index bb40517..2214286 100644 > --- a/arch/x86/lib/zimage.c > +++ b/arch/x86/lib/zimage.c > @@ -314,6 +314,13 @@ void boot_zimage(void *setup_base, void *load_address) > #endif > } > > +void setup_pcat_compatibility(void) > + __attribute__((weak, alias("__setup_pcat_compatibility"))); > + > +void __setup_pcat_compatibility(void) > +{ > +} > + > int do_zboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) > { > struct boot_params *base_ptr; > -- > 1.7.5.2.317.g391b14 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
Hi Simon, On 04/01/12 16:48, Simon Glass wrote: > Hi Graeme, > > On Sun, Jan 1, 2012 at 8:09 PM, Graeme Russ <graeme.russ@gmail.com> wrote: >> >> Signed-off-by: Graeme Russ <graeme.russ@gmail.com> > > Perhaps mention why? Anyway: Added commit message 'This function simply does not belong in board.c' Regards, Graeme
diff --git a/arch/x86/lib/board.c b/arch/x86/lib/board.c index 533adf1..993e7df 100644 --- a/arch/x86/lib/board.c +++ b/arch/x86/lib/board.c @@ -486,10 +486,3 @@ void hang(void) for (;;) ; } - -void setup_pcat_compatibility(void) - __attribute__((weak, alias("__setup_pcat_compatibility"))); - -void __setup_pcat_compatibility(void) -{ -} diff --git a/arch/x86/lib/zimage.c b/arch/x86/lib/zimage.c index bb40517..2214286 100644 --- a/arch/x86/lib/zimage.c +++ b/arch/x86/lib/zimage.c @@ -314,6 +314,13 @@ void boot_zimage(void *setup_base, void *load_address) #endif } +void setup_pcat_compatibility(void) + __attribute__((weak, alias("__setup_pcat_compatibility"))); + +void __setup_pcat_compatibility(void) +{ +} + int do_zboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) { struct boot_params *base_ptr;
Signed-off-by: Graeme Russ <graeme.russ@gmail.com> --- arch/x86/lib/board.c | 7 ------- arch/x86/lib/zimage.c | 7 +++++++ 2 files changed, 7 insertions(+), 7 deletions(-)