Patchwork [net-next] sch_tbf: report backlog information

login
register
mail settings
Submitter Eric Dumazet
Date Dec. 29, 2011, 9:27 a.m.
Message ID <1325150864.2607.37.camel@edumazet-laptop>
Download mbox | patch
Permalink /patch/133511/
State Accepted
Delegated to: David Miller
Headers show

Comments

Eric Dumazet - Dec. 29, 2011, 9:27 a.m.
Provide child qdisc backlog (byte count) information so that "tc -s
qdisc" can report it to user.

qdisc netem 30: root refcnt 18 limit 1000 delay 20.0ms  10.0ms
 Sent 948517 bytes 898 pkt (dropped 0, overlimits 0 requeues 1) 
 rate 175056bit 16pps backlog 114b 1p requeues 1 
qdisc tbf 40: parent 30: rate 256000bit burst 20Kb/8 mpu 0b lat 0us 
 Sent 948517 bytes 898 pkt (dropped 15, overlimits 611 requeues 0) 
 backlog 18168b 12p requeues 0 

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
 net/sched/sch_tbf.c |    1 +
 1 file changed, 1 insertion(+)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Dec. 29, 2011, 8:07 p.m.
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 29 Dec 2011 10:27:44 +0100

> Provide child qdisc backlog (byte count) information so that "tc -s
> qdisc" can report it to user.
> 
> qdisc netem 30: root refcnt 18 limit 1000 delay 20.0ms  10.0ms
>  Sent 948517 bytes 898 pkt (dropped 0, overlimits 0 requeues 1) 
>  rate 175056bit 16pps backlog 114b 1p requeues 1 
> qdisc tbf 40: parent 30: rate 256000bit burst 20Kb/8 mpu 0b lat 0us 
>  Sent 948517 bytes 898 pkt (dropped 15, overlimits 611 requeues 0) 
>  backlog 18168b 12p requeues 0 
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c
index 1dcfb52..b8e1563 100644
--- a/net/sched/sch_tbf.c
+++ b/net/sched/sch_tbf.c
@@ -346,6 +346,7 @@  static int tbf_dump(struct Qdisc *sch, struct sk_buff *skb)
 	struct nlattr *nest;
 	struct tc_tbf_qopt opt;
 
+	sch->qstats.backlog = q->qdisc->qstats.backlog;
 	nest = nla_nest_start(skb, TCA_OPTIONS);
 	if (nest == NULL)
 		goto nla_put_failure;