From patchwork Thu Dec 29 06:48:50 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Zumbiehl X-Patchwork-Id: 133503 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0C85CB6FC5 for ; Thu, 29 Dec 2011 17:49:23 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751333Ab1L2Gs6 (ORCPT ); Thu, 29 Dec 2011 01:48:58 -0500 Received: from rain.florz.de ([62.216.164.86]:55548 "EHLO rain.florz.dyndns.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751019Ab1L2Gs5 (ORCPT ); Thu, 29 Dec 2011 01:48:57 -0500 Received: from florz.florz.dyndns.org ([192.168.0.121]) by rain.florz.dyndns.org with esmtp (Exim 4.69) (envelope-from ) id 1Rg9nG-0000dT-DJ; Thu, 29 Dec 2011 07:48:50 +0100 Received: from florz by florz.florz.dyndns.org with local (Exim 4.72) (envelope-from ) id 1Rg9nG-0008OP-50; Thu, 29 Dec 2011 07:48:50 +0100 Date: Thu, 29 Dec 2011 07:48:50 +0100 From: Florian Zumbiehl To: David Miller Cc: shemminger@vyatta.com, netdev@vger.kernel.org Subject: Re: [PATCH] skge: restore multicast rx filter on resume Message-ID: <20111229064849.GB8041@florz.florz.dyndns.org> References: <20111227095635.19087752@nehalam.linuxnetplumber.net> <20111228074143.GA8041@florz.florz.dyndns.org> <20111228092714.0a6d5f80@nehalam.linuxnetplumber.net> <20111228.130908.182833189468208987.davem@davemloft.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20111228.130908.182833189468208987.davem@davemloft.net> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, > Florian, please formally resubmit this with proper changelog and > Stephen's ack. Erm, yeah, indeed. Well, there you go ... Florian --------------------------------------------------------------------------- skge: restore rx multicast filter on resume and after config changes Restore skge hardware registers for multicast filtering to their appropriate values after system resume and after hardware restarts that are done when changing certain settings. Signed-off-by: Florian Zumbiehl Acked-by: Stephen Hemminger --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/skge.c b/drivers/net/skge.c index f4be5c7..8f985a8 100644 --- a/drivers/net/skge.c +++ b/drivers/net/skge.c @@ -2587,6 +2587,9 @@ static int skge_up(struct net_device *dev) spin_unlock_irq(&hw->hw_lock); napi_enable(&skge->napi); + + skge_set_multicast(dev); + return 0; free_rx_ring: