Patchwork skge: restore multicast rx filter on resume

login
register
mail settings
Submitter Florian Zumbiehl
Date Dec. 29, 2011, 6:48 a.m.
Message ID <20111229064849.GB8041@florz.florz.dyndns.org>
Download mbox | patch
Permalink /patch/133503/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Florian Zumbiehl - Dec. 29, 2011, 6:48 a.m.
Hi,

> Florian, please formally resubmit this with proper changelog and
> Stephen's ack.

Erm, yeah, indeed. Well, there you go ...

Florian

---------------------------------------------------------------------------
skge: restore rx multicast filter on resume and after config changes

Restore skge hardware registers for multicast filtering to their
appropriate values after system resume and after hardware restarts
that are done when changing certain settings.

Signed-off-by: Florian Zumbiehl <florz@florz.de>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Dec. 29, 2011, 7:56 a.m.
From: Florian Zumbiehl <florz@florz.de>
Date: Thu, 29 Dec 2011 07:48:50 +0100

> --- a/drivers/net/skge.c
> +++ b/drivers/net/skge.c

This file no longer exists in the current source tree.

All of the ethernet drivers have been moved to various directories
under drivers/net/ethernet

Please do not generate patches against older source trees.

And when I ask you to post a patch anew, please make it clean.  In
this case you replied to my email, added some unrelated commentary,
and then included the commit log message and the patch.

This is not the correct way to do things.  Post a fresh email, not a
reply, with a clean Subject line and the email body contents only
contain the commit log message and the subsequent patch.

If you don't do things the correct way, then the person applying your
patch has to do a lot of work editing things.  If you do it the right
way, adding your patch is very easy.

See:

	http://linux.yyz.us/patch-format.html

for more details
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
stephen hemminger - Dec. 29, 2011, 4:18 p.m.
On Thu, 29 Dec 2011 02:56:11 -0500 (EST)
David Miller <davem@davemloft.net> wrote:

> From: Florian Zumbiehl <florz@florz.de>
> Date: Thu, 29 Dec 2011 07:48:50 +0100
> 
> > --- a/drivers/net/skge.c
> > +++ b/drivers/net/skge.c  
> 
> This file no longer exists in the current source tree.

Florian the driver has moved to:
  drivers/net/ethernet/marvell/skge.c
in latest kernel release.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index f4be5c7..8f985a8 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -2587,6 +2587,9 @@  static int skge_up(struct net_device *dev)
 	spin_unlock_irq(&hw->hw_lock);
 
 	napi_enable(&skge->napi);
+
+	skge_set_multicast(dev);
+
 	return 0;
 
  free_rx_ring: