From patchwork Thu Dec 29 02:03:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Marlier X-Patchwork-Id: 133481 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 6D6AEB6FB9 for ; Thu, 29 Dec 2011 13:04:26 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1325729067; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC: Subject:Content-Type:Content-Transfer-Encoding:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=m6TfmnIQSvEoznAd0CEssXX1KZ4=; b=ZbK+sEfVIOo8tIPhCVdjtnaXWfa0izItdpjvwZG3r2Soah+m4zTU5425P0BF4X c8Mld16MT1CkaSLnSkIVMOtic7bQSdlSlTxd/yGYfPz/F+AnJfdwBBoWwe1xhyHz 3q2CQd4IryqmCW8YQdxEdOiqTYVHfhkL7hnxY+CdnzEFo= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:Content-Type:Content-Transfer-Encoding:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=hU/ZtQXk3kf51ehv6eSrX+FOTt9A+7zlJN2fGE62xnAO76qfTdo9S7/nvPh3t6 DlF5JAfeydMsDi926S1XH1OfrvYDgvDnAkRBmfbNRJKgowGa4OJBlue69bKpERcy yADs6fyeGrdByUUFfPQmQeJy9Gwa7zIUpRVOid5b8qjto=; Received: (qmail 21316 invoked by alias); 29 Dec 2011 02:04:22 -0000 Received: (qmail 21305 invoked by uid 22791); 29 Dec 2011 02:04:20 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qw0-f54.google.com (HELO mail-qw0-f54.google.com) (209.85.216.54) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Dec 2011 02:03:55 +0000 Received: by qabg14 with SMTP id g14so9155124qab.20 for ; Wed, 28 Dec 2011 18:03:54 -0800 (PST) Received: by 10.224.39.81 with SMTP id f17mr40969433qae.63.1325124234449; Wed, 28 Dec 2011 18:03:54 -0800 (PST) Received: from [192.168.2.2] (cpe-69-207-95-157.rochester.res.rr.com. [69.207.95.157]) by mx.google.com with ESMTPS id q14sm61881023qap.4.2011.12.28.18.03.53 (version=SSLv3 cipher=OTHER); Wed, 28 Dec 2011 18:03:53 -0800 (PST) Message-ID: <4EFBCA88.7060801@gmail.com> Date: Wed, 28 Dec 2011 21:03:52 -0500 From: Patrick Marlier User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111124 Thunderbird/8.0 MIME-Version: 1.0 To: Richard Henderson CC: gcc-patches , Torvald Riegel , Aldy Hernandez Subject: [libitm] Remove variadic argument of _ITM_beginTransaction from libitm.h X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org With i386, the regparm(2) is not taken into account when there is a variadic function. All parameters are in the stack. Since this variable argument is never used removing it is not a problem. This solves libitm testcases memset-1.c/memcpy-1.c on i686 (part of PR51655/51124). Before: FAIL: libitm.c/memcpy-1.c execution test FAIL: libitm.c/memset-1.c execution test === libitm Summary === # of expected passes 21 # of unexpected failures 2 # of expected failures 5 # of unresolved testcases 1 After: === libitm Summary === # of expected passes 23 # of expected failures 5 # of unresolved testcases 1 Tested on i686. If ok, please commit. Thanks. Patrick Marlier. 2011-12-28 Patrick Marlier PR testsuite/51655 * libitm.h (_ITM_beginTransaction): Remove unused argument. Index: libitm.h =================================================================== --- libitm.h (revision 182549) +++ libitm.h (working copy) @@ -136,7 +136,7 @@ typedef uint64_t _ITM_transactionId_t; /* Transact extern _ITM_transactionId_t _ITM_getTransactionId(void) ITM_REGPARM; -extern uint32_t _ITM_beginTransaction(uint32_t, ...) ITM_REGPARM; +extern uint32_t _ITM_beginTransaction(uint32_t) ITM_REGPARM; extern void _ITM_abortTransaction(_ITM_abortReason) ITM_REGPARM ITM_NORETURN;