| Message ID | 20111225081833.GC3088@florz.florz.dyndns.org |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Florian Zumbiehl <florz@florz.de> Date: Sun, 25 Dec 2011 09:18:33 +0100 > skge: restore multicast rx filter on resume > > Signed-off-by: Florian Zumbiehl <florz@florz.de> Stephen? This one looks fine to me. > diff --git a/drivers/net/skge.c b/drivers/net/skge.c > index f4be5c7..cd968e5 100644 > --- a/drivers/net/skge.c > +++ b/drivers/net/skge.c > @@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev) > dev_close(dev); > goto out; > } > + skge_set_multicast(dev); > } > } > out: > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 26 Dec 2011 15:17:54 -0500 (EST) David Miller <davem@davemloft.net> wrote: > From: Florian Zumbiehl <florz@florz.de> > Date: Sun, 25 Dec 2011 09:18:33 +0100 > > > skge: restore multicast rx filter on resume > > > > Signed-off-by: Florian Zumbiehl <florz@florz.de> > > Stephen? This one looks fine to me. > > > diff --git a/drivers/net/skge.c b/drivers/net/skge.c > > index f4be5c7..cd968e5 100644 > > --- a/drivers/net/skge.c > > +++ b/drivers/net/skge.c > > @@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev) > > dev_close(dev); > > goto out; > > } > > + skge_set_multicast(dev); > > } > > } > > out: Right idea, but it needs to be done in a different spot to catch all the other device restart cases like changing settings. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/skge.c b/drivers/net/skge.c index f4be5c7..cd968e5 100644 --- a/drivers/net/skge.c +++ b/drivers/net/skge.c @@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev) dev_close(dev); goto out; } + skge_set_multicast(dev); } } out:
Hi, no clue whether this is really the correct[tm] way to fix this, but it makes it so that IPv6 doesn't start failing after a suspend/resume cycle because neighbour discovery stops working ... Florian --------------------------------------------------------------------------- skge: restore multicast rx filter on resume Signed-off-by: Florian Zumbiehl <florz@florz.de> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html