From patchwork Wed Dec 10 19:40:44 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Detsch X-Patchwork-Id: 13311 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 91FF7DDF94 for ; Thu, 11 Dec 2008 06:44:24 +1100 (EST) X-Original-To: cbe-oss-dev@ozlabs.org Delivered-To: cbe-oss-dev@ozlabs.org Received: from igw1.br.ibm.com (igw1.br.ibm.com [32.104.18.24]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DF954DDF9E for ; Thu, 11 Dec 2008 06:40:52 +1100 (EST) Received: from d24relay01.br.ibm.com (unknown [9.8.31.16]) by igw1.br.ibm.com (Postfix) with ESMTP id ECCB732C024 for ; Wed, 10 Dec 2008 17:36:45 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mBAKeL3x3821810 for ; Wed, 10 Dec 2008 17:40:21 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mBAJelKh017472 for ; Wed, 10 Dec 2008 17:40:47 -0200 Received: from [9.8.13.23] ([9.8.13.23]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id mBAJegsZ017084 for ; Wed, 10 Dec 2008 17:40:46 -0200 From: Andre Detsch To: cbe-oss-dev@ozlabs.org Date: Wed, 10 Dec 2008 17:40:44 -0200 User-Agent: KMail/1.9.6 References: <200812101719.42964.adetsch@br.ibm.com> In-Reply-To: <200812101719.42964.adetsch@br.ibm.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200812101740.45046.adetsch@br.ibm.com> Subject: [Cbe-oss-dev] [PATCH 15/18] powerpc/spufs: Fix position of BUG_ON inside spusched_tick X-BeenThere: cbe-oss-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Discussion about Open Source Software for the Cell Broadband Engine List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cbe-oss-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: cbe-oss-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org The old position of the BUG_ON(!spu_gang_runnable(gang)) command was leading to false bug notifications. The gang might become not runnable when spusched_tick is about to be called, as there is no lock being hold that prevents this to happen. It only is a bug if ctx->spu was not unset during the process. Signed-off-by: Andre Detsch --- arch/powerpc/platforms/cell/spufs/sched.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/sched.c b/arch/powerpc/platforms/cell/spufs/sched.c index be13b19..7b4852f 100644 --- a/arch/powerpc/platforms/cell/spufs/sched.c +++ b/arch/powerpc/platforms/cell/spufs/sched.c @@ -1160,11 +1160,11 @@ static noinline int spusched_tick(struct spu_gang *gang, mutex_lock(&gang->mutex); - BUG_ON(!spu_gang_runnable(gang)); - if (!ctx->spu) goto out; + BUG_ON(!spu_gang_runnable(gang)); + if (ctx->flags & SPU_CREATE_NOSCHED) goto out;