| Submitter | Wolfgang Denk |
|---|---|
| Date | Dec. 23, 2011, 11:29 a.m. |
| Message ID | <1324639752-26856-2-git-send-email-wd@denx.de> |
| Download | mbox | patch |
| Permalink | /patch/132989/ |
| State | Accepted |
| Headers | show |
Comments
On Fri, 23 Dec 2011 12:29:11 +0100 Wolfgang Denk <wd@denx.de> wrote: > Clean up and document the code: > > - get rid of unneeded code block > - add comment which code is generated > > Signed-off-by: Wolfgang Denk <wd@denx.de> > Cc: Anatolij Gustschin <agust@denx.de> > Cc: Stefan Roese <sr@denx.de> > Cc: Kumar Gala <galak@kernel.crashing.org> > Cc: Kim Phillips <kim.phillips@freescale.com> > Cc: Andy Fleming <afleming@gmail.com> Acked-by: Anatolij Gustschin <agust@denx.de>
Dear Wolfgang Denk, In message <1324639752-26856-2-git-send-email-wd@denx.de> you wrote: > Clean up and document the code: > > - get rid of unneeded code block > - add comment which code is generated > > Signed-off-by: Wolfgang Denk <wd@denx.de> > Cc: Anatolij Gustschin <agust@denx.de> > Cc: Stefan Roese <sr@denx.de> > Cc: Kumar Gala <galak@kernel.crashing.org> > Cc: Kim Phillips <kim.phillips@freescale.com> > Cc: Andy Fleming <afleming@gmail.com> > --- > post/lib_powerpc/multi.c | 27 ++++++++++++--------------- > 1 files changed, 12 insertions(+), 15 deletions(-) Applied, thanks. Best regards, Wolfgang Denk
Patch
diff --git a/post/lib_powerpc/multi.c b/post/lib_powerpc/multi.c index 4b4b119..b8619de 100644 --- a/post/lib_powerpc/multi.c +++ b/post/lib_powerpc/multi.c @@ -44,26 +44,23 @@ int cpu_post_test_multi(void) { int ret = 0; unsigned int i; + ulong src[26], dst[26]; int flag = disable_interrupts(); - if (ret == 0) { - ulong src[26], dst[26]; + ulong code[] = { + ASM_LMW(5, 3, 0), /* lmw r5, 0(r3) */ + ASM_STMW(5, 4, 0), /* stmr r5, 0(r4) */ + ASM_BLR, /* blr */ + }; - ulong code[] = { - ASM_LMW(5, 3, 0), - ASM_STMW(5, 4, 0), - ASM_BLR, - }; - - for (i = 0; i < ARRAY_SIZE(src); ++i) { - src[i] = i; - dst[i] = 0; - } + for (i = 0; i < ARRAY_SIZE(src); ++i) { + src[i] = i; + dst[i] = 0; + } - cpu_post_exec_02(code, (ulong) src, (ulong) dst); + cpu_post_exec_02(code, (ulong) src, (ulong) dst); - ret = memcmp(src, dst, sizeof(dst)) == 0 ? 0 : -1; - } + ret = memcmp(src, dst, sizeof(dst)) == 0 ? 0 : -1; if (ret != 0) { post_log("Error at multi test !\n");
Clean up and document the code: - get rid of unneeded code block - add comment which code is generated Signed-off-by: Wolfgang Denk <wd@denx.de> Cc: Anatolij Gustschin <agust@denx.de> Cc: Stefan Roese <sr@denx.de> Cc: Kumar Gala <galak@kernel.crashing.org> Cc: Kim Phillips <kim.phillips@freescale.com> Cc: Andy Fleming <afleming@gmail.com> --- post/lib_powerpc/multi.c | 27 ++++++++++++--------------- 1 files changed, 12 insertions(+), 15 deletions(-)