Patchwork [git] libata build fix for 3.2-rc

login
register
mail settings
Submitter Jeff Garzik
Date Dec. 22, 2011, 8:20 p.m.
Message ID <20111222202017.GA13208@havoc.gtf.org>
Download mbox | patch
Permalink /patch/132899/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Jeff Garzik - Dec. 22, 2011, 8:20 p.m.
A sparc build fix...


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Please pull 19d40dcabf1cdf84e1a76c147b7177b5a6c21943 from
git://github.com/jgarzik/libata-dev.git upstream-linus

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIVAwUBTvOQqCWzCDIBeCsvAQJRiw//bqZDQFOcfpwPpY3P1Frimer5UbZALGDd
8sIYctAKDz1OfgH1e1Sm7lvoJKcmBl0U4QNgp7SkiT9QfOZCg81Cw9ZyJCUQE2F7
sqGBBP1Pg+3qsCTYZY4aqcd2skfrKvX3KX+fapW7+C8WriAgwvyYzyLqyCcYu7hf
g3J6tmTMPdGyppUj/1yRJbGqrIorc+jtKHQoO7ASYGAe0eLWCFMA4o6ml25af1OF
z62AuKpY0RzNTYcBtzYdipHUBX4ZNyhKkGK68x+m2vnbIIDYTlAsqW/9tiLEfSdt
sKBknSx3O3z6zb+EZpO5xXax6ED2YnGsHlj9k49sZ/hCuhOErUUGvU8b9nJW/xkM
j2meZBWQSu5ceJuZCbq94Qe5VKY4YCmmge6xpHsoEuwXDPbZfGjpM93ePwlSyKtr
wtxLkIKuZQIqGYieY5+sVSXyp2/H76p6Pyp4XSCrEAxKW0IlaPQNr5VrroF+i2bE
uua/41WHoIBFdlS0rU5hkXo6nSSCVFUXZa5nT2xFoxsBYr/iP10WmuHQz4A77ocp
cTUDC5dB4n4zy0TLbOm7MKHQ5YPh68cqySwM8FLlj4uaea2aKAZqFq2Lfuw/acLA
ngsffDOTpSyKc8lp/fwUIQ9no3pCvsHOwaDDKEsV6LT8RQ1GHfEjF1RHPMgpi35A
bKhObdycgnU=
=flSW
-----END PGP SIGNATURE-----

to receive the following updates:

 drivers/ata/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

David Miller (1):
      pata_of_platform: Add missing CONFIG_OF_IRQ dependency.

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Torvalds - Dec. 22, 2011, 8:59 p.m.
On Thu, Dec 22, 2011 at 12:20 PM, Jeff Garzik <jeff@garzik.org> wrote:
>
> A sparc build fix...

Pulled..

> -----BEGIN PGP SIGNED MESSAGE-----

And these days it would actually be better if you just use git signed
tags instead, and ask me to pull them. You don't need to do anything
special per se (just "git tag -s" to create the signature, and then
"git push -tags" to push it out), it's only the merger who has to then
have a recent enough git version that pulling the tag will DTRT. And I
do.

So then you don't need to do this send-time PGP signature, and git
will now verify (and save) the signature automatically.

See
  https://lkml.org/lkml/2011/12/14/543

that I sent to Ted about how it ends up looking - you can check out
that commit 2240a7bb479c with "git show" and "git cat-file commit" to
see how your signature would be archived and saved without actually
being bothersome when just looking at the history.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Junio C Hamano - Dec. 22, 2011, 10:09 p.m.
Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Thu, Dec 22, 2011 at 12:20 PM, Jeff Garzik <jeff@garzik.org> wrote:
>>
>> A sparc build fix...
>
> Pulled..
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>
> And these days it would actually be better if you just use git signed
> tags instead, and ask me to pull them. You don't need to do anything
> special per se (just "git tag -s" to create the signature, and then
> "git push -tags" to push it out), it's only the merger who has to then
> have a recent enough git version that pulling the tag will DTRT. And I
> do.

"git push --tags" may be a bit too much. A lieutenant can just push that
signed tag being requested to get pulled and nothing else. And after the
integrator responds to the request, the signed tag can be removed from the
publishing repository of the requestor to keep namespace clean and neat.

> See
>   https://lkml.org/lkml/2011/12/14/543
>
> that I sent to Ted about how it ends up looking - you can check out
> that commit 2240a7bb479c with "git show" and "git cat-file commit" to
> see how your signature would be archived and saved without actually
> being bothersome when just looking at the history.

This falls into a shameless plug category, but at http://goo.gl/3OImV
there is my write-up on the whole workflow.

We would need to add some Porcelain support for third-party (as opposed to
the integrator who is resonding to the pull request and verifies the
signed tag himself) auditors, by the way.

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 6bdedd7..cf047c4 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -820,7 +820,7 @@  config PATA_PLATFORM
 
 config PATA_OF_PLATFORM
 	tristate "OpenFirmware platform device PATA support"
-	depends on PATA_PLATFORM && OF
+	depends on PATA_PLATFORM && OF && OF_IRQ
 	help
 	  This option enables support for generic directly connected ATA
 	  devices commonly found on embedded systems with OpenFirmware