diff mbox

[U-Boot] MX28: Fix MXSBOOT segfault if no params specified

Message ID 1324583708-19459-1-git-send-email-marek.vasut@gmail.com
State Accepted
Commit e364daf92593e88ea8e26e31e987b1527338869c
Delegated to: Stefano Babic
Headers show

Commit Message

Marek Vasut Dec. 22, 2011, 7:55 p.m. UTC 
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
---
 tools/mxsboot.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Comments

Marek Vasut Jan. 3, 2012, 9:19 p.m. UTC | #1 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
>  tools/mxsboot.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/mxsboot.c b/tools/mxsboot.c
> index 176753d..8246831 100644
> --- a/tools/mxsboot.c
> +++ b/tools/mxsboot.c
> @@ -606,6 +606,9 @@ int parse_ops(int argc, char **argv)
>  	};
>  	int type;
> 
> +	if (argc < 4)
> +		return -1;
> +
>  	for (i = 1; i < argc; i++) {
>  		if (!strncmp(argv[i], "-w", 2))
>  			type = PARAM_WRITE;

BUMP
Stefano Babic Jan. 4, 2012, 1:38 p.m. UTC | #2 
On 22/12/2011 20:55, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
>  tools/mxsboot.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/mxsboot.c b/tools/mxsboot.c
> index 176753d..8246831 100644

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/tools/mxsboot.c b/tools/mxsboot.c
index 176753d..8246831 100644
--- a/tools/mxsboot.c
+++ b/tools/mxsboot.c
@@ -606,6 +606,9 @@  int parse_ops(int argc, char **argv)
 	};
 	int type;
 
+	if (argc < 4)
+		return -1;
+
 	for (i = 1; i < argc; i++) {
 		if (!strncmp(argv[i], "-w", 2))
 			type = PARAM_WRITE;