| Message ID | 1324477932-19262-3-git-send-email-monstr@monstr.eu |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Dec 21, 2011 at 03:32:11PM +0100, Michal Simek wrote: > Drivers shouldn't use NO_IRQ. Microblaze and PPC > define NO_IRQ as 0 and this reference will be removed > in near future. > > Signed-off-by: Michal Simek <monstr@monstr.eu> > CC: Grant Likely <grant.likely@secretlab.ca> > CC: Rob Herring <rob.herring@calxeda.com> > CC: Ryan Mallon <rmallon@gmail.com> Acked-by: Grant Likely <grant.likely@secretlab.ca> > --- > drivers/input/serio/xilinx_ps2.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c > index d64c5a4..f3e54b9 100644 > --- a/drivers/input/serio/xilinx_ps2.c > +++ b/drivers/input/serio/xilinx_ps2.c > @@ -253,7 +253,7 @@ static int __devinit xps2_of_probe(struct platform_device *ofdev) > } > > /* Get IRQ for the device */ > - if (of_irq_to_resource(ofdev->dev.of_node, 0, &r_irq) == NO_IRQ) { > + if (!of_irq_to_resource(ofdev->dev.of_node, 0, &r_irq)) { > dev_err(dev, "no IRQ found\n"); > return -ENODEV; > } > -- > 1.7.5.4 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c index d64c5a4..f3e54b9 100644 --- a/drivers/input/serio/xilinx_ps2.c +++ b/drivers/input/serio/xilinx_ps2.c @@ -253,7 +253,7 @@ static int __devinit xps2_of_probe(struct platform_device *ofdev) } /* Get IRQ for the device */ - if (of_irq_to_resource(ofdev->dev.of_node, 0, &r_irq) == NO_IRQ) { + if (!of_irq_to_resource(ofdev->dev.of_node, 0, &r_irq)) { dev_err(dev, "no IRQ found\n"); return -ENODEV; }
Drivers shouldn't use NO_IRQ. Microblaze and PPC define NO_IRQ as 0 and this reference will be removed in near future. Signed-off-by: Michal Simek <monstr@monstr.eu> CC: Grant Likely <grant.likely@secretlab.ca> CC: Rob Herring <rob.herring@calxeda.com> CC: Ryan Mallon <rmallon@gmail.com> --- drivers/input/serio/xilinx_ps2.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)