Patchwork [U-Boot,V2,1/2] Exynos: PWM: Add TCMPB3 field in pwm structure

login
register
mail settings
Submitter Chander Kashyap
Date Dec. 19, 2011, 8:56 a.m.
Message ID <1324285004-32354-2-git-send-email-chander.kashyap@linaro.org>
Download mbox | patch
Permalink /patch/132168/
State Accepted
Delegated to: Minkyu Kang
Headers show

Comments

Chander Kashyap - Dec. 19, 2011, 8:56 a.m.
Add TCMPB3 field in pwm structure, earliar this was res1.

Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
---
 arch/arm/include/asm/arch-exynos/pwm.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Wolfgang Denk - Dec. 19, 2011, 9:03 a.m.
Dear Chander Kashyap,

In message <1324285004-32354-2-git-send-email-chander.kashyap@linaro.org> you wrote:
> Add TCMPB3 field in pwm structure, earliar this was res1.
> 
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> ---
>  arch/arm/include/asm/arch-exynos/pwm.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-exynos/pwm.h b/arch/arm/include/asm/arch-exynos/pwm.h
> index d0cf3cb..3e95160 100644

You submit a V2 patch, but without any indication what was changed ???

Where is the _mandatory_ change log?

Best regards,

Wolfgang Denk
Chander Kashyap - Dec. 19, 2011, 9:05 a.m.
Hi Wolfgsng Denk,

On 19 December 2011 14:33, Wolfgang Denk <wd@denx.de> wrote:

> Dear Chander Kashyap,
>
> In message <1324285004-32354-2-git-send-email-chander.kashyap@linaro.org>
> you wrote:
> > Add TCMPB3 field in pwm structure, earliar this was res1.
> >
> > Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> > ---
> >  arch/arm/include/asm/arch-exynos/pwm.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/include/asm/arch-exynos/pwm.h
> b/arch/arm/include/asm/arch-exynos/pwm.h
> > index d0cf3cb..3e95160 100644
>
> You submit a V2 patch, but without any indication what was changed ???
>
Changes are in Patch2/2. I have mentioned them in Patch2/2.

>
> Where is the _mandatory_ change log?
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
> Always try to do things in chronological order; it's  less  confusing
> that way.
>
Minkyu Kang - Jan. 4, 2012, 4:38 a.m.
Dear Chander Kashyap,

On 19 December 2011 17:56, Chander Kashyap <chander.kashyap@linaro.org> wrote:
> Add TCMPB3 field in pwm structure, earliar this was res1.
>
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> ---
>  arch/arm/include/asm/arch-exynos/pwm.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>

applied to u-boot-samsung.
Thanks,Minkyu Kang.--
from. prom.
www.promsoft.net

Patch

diff --git a/arch/arm/include/asm/arch-exynos/pwm.h b/arch/arm/include/asm/arch-exynos/pwm.h
index d0cf3cb..3e95160 100644
--- a/arch/arm/include/asm/arch-exynos/pwm.h
+++ b/arch/arm/include/asm/arch-exynos/pwm.h
@@ -57,7 +57,7 @@  struct s5p_timer {
 	unsigned int	tcmpb2;
 	unsigned int	tcnto2;
 	unsigned int	tcntb3;
-	unsigned int	res1;
+	unsigned int	tcmpb3;
 	unsigned int	tcnto3;
 	unsigned int	tcntb4;
 	unsigned int	tcnto4;