Patchwork [07/10] hw/sd.c: Set ILLEGAL_COMMAND for ACMDs in invalid state

login
register
mail settings
Submitter Peter Maydell
Date Dec. 18, 2011, 8:37 p.m.
Message ID <1324240680-26905-8-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/132118/
State New
Headers show

Comments

Peter Maydell - Dec. 18, 2011, 8:37 p.m.
App commands in an invalid state should set ILLEGAL_COMMAND, not
merely return a zero response.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/sd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/hw/sd.c b/hw/sd.c
index 9116f67..9eebfac 100644
--- a/hw/sd.c
+++ b/hw/sd.c
@@ -1262,7 +1262,7 @@  static sd_rsp_type_t sd_app_command(SDState *sd,
     }
 
     fprintf(stderr, "SD: ACMD%i in a wrong state\n", req.cmd);
-    return sd_r0;
+    return sd_illegal;
 }
 
 static int cmd_valid_while_locked(SDState *sd, SDRequest *req)