From patchwork Sun Dec 18 16:05:06 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 132095 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C6D74B7044 for ; Mon, 19 Dec 2011 03:05:44 +1100 (EST) Received: from localhost ([::1]:34599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcJEz-0001hD-NF for incoming@patchwork.ozlabs.org; Sun, 18 Dec 2011 11:05:33 -0500 Received: from eggs.gnu.org ([140.186.70.92]:42096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcJEm-0001Xa-9V for qemu-devel@nongnu.org; Sun, 18 Dec 2011 11:05:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RcJEl-00071h-9C for qemu-devel@nongnu.org; Sun, 18 Dec 2011 11:05:20 -0500 Received: from mail-ee0-f45.google.com ([74.125.83.45]:39149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcJEl-000712-4R for qemu-devel@nongnu.org; Sun, 18 Dec 2011 11:05:19 -0500 Received: by mail-ee0-f45.google.com with SMTP id b45so5270371eek.4 for ; Sun, 18 Dec 2011 08:05:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=Sw6tef8YcPA0JrBwWDsfuin1ySn9naR0Dyz5e6JpLY0=; b=MWop31gi7GAF75bqGeOc7WMSlwDpup4yvmhg/2b+uK3eZ3GWG6H+j7rU259PtGnQQv YWb/3W/kcF3DXjbuyW2ygkUll34Ssv5zp84k4aiAtQxwj0lTWjcafuJbnEOLVrFDkENV nha+EkZkWyh7cSvE8VFvAvwys+wmdy6J/z2aA= Received: by 10.213.108.132 with SMTP id f4mr2032371ebp.35.1324224318807; Sun, 18 Dec 2011 08:05:18 -0800 (PST) Received: from localhost.localdomain (93-34-178-147.ip50.fastwebnet.it. [93.34.178.147]) by mx.google.com with ESMTPS id t59sm14059180eeh.10.2011.12.18.08.05.17 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Dec 2011 08:05:18 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sun, 18 Dec 2011 17:05:06 +0100 Message-Id: <1324224311-25032-4-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.7.1 In-Reply-To: <1324224311-25032-1-git-send-email-pbonzini@redhat.com> References: <1324224311-25032-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.83.45 Subject: [Qemu-devel] [PATCH 3/8] qom: push permission checks up into qdev_property_add_legacy X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org qdev_property_get and qdev_property_set can generate permission denied errors themselves. Do not duplicate this functionality in qdev_get/set_legacy_property, and clean up excessive indentation. Reviewed-by: Anthony Liguori Signed-off-by: Paolo Bonzini --- hw/qdev.c | 46 +++++++++++++++++++--------------------------- 1 files changed, 19 insertions(+), 27 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index bda8d6c..c020a6f 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -1135,46 +1135,38 @@ static void qdev_get_legacy_property(DeviceState *dev, Visitor *v, void *opaque, { Property *prop = opaque; - if (prop->info->print) { - char buffer[1024]; - char *ptr = buffer; + char buffer[1024]; + char *ptr = buffer; - prop->info->print(dev, prop, buffer, sizeof(buffer)); - visit_type_str(v, &ptr, name, errp); - } else { - error_set(errp, QERR_PERMISSION_DENIED); - } + prop->info->print(dev, prop, buffer, sizeof(buffer)); + visit_type_str(v, &ptr, name, errp); } static void qdev_set_legacy_property(DeviceState *dev, Visitor *v, void *opaque, const char *name, Error **errp) { Property *prop = opaque; + Error *local_err = NULL; + char *ptr = NULL; + int ret; if (dev->state != DEV_STATE_CREATED) { error_set(errp, QERR_PERMISSION_DENIED); return; } - if (prop->info->parse) { - Error *local_err = NULL; - char *ptr = NULL; + visit_type_str(v, &ptr, name, &local_err); + if (local_err) { + error_propagate(errp, local_err); + return; + } - visit_type_str(v, &ptr, name, &local_err); - if (!local_err) { - int ret; - ret = prop->info->parse(dev, prop, ptr); - if (ret != 0) { - error_set(errp, QERR_INVALID_PARAMETER_VALUE, - name, prop->info->name); - } - g_free(ptr); - } else { - error_propagate(errp, local_err); - } - } else { - error_set(errp, QERR_PERMISSION_DENIED); + ret = prop->info->parse(dev, prop, ptr); + if (ret != 0) { + error_set(errp, QERR_INVALID_PARAMETER_VALUE, + name, prop->info->name); } + g_free(ptr); } /** @@ -1194,8 +1186,8 @@ void qdev_property_add_legacy(DeviceState *dev, Property *prop, type = g_strdup_printf("legacy<%s>", prop->info->name); qdev_property_add(dev, prop->name, type, - qdev_get_legacy_property, - qdev_set_legacy_property, + prop->info->print ? qdev_get_legacy_property : NULL, + prop->info->parse ? qdev_set_legacy_property : NULL, NULL, prop, errp);