From patchwork Sun Dec 18 08:32:36 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: testsuite typo fixed in "[PATCH, PR51491] add CLOBBER before __builtin_stack_restore" when converting vla alloca_with_align to array decl Date: Sat, 17 Dec 2011 22:32:36 -0000 From: Hans-Peter Nilsson X-Patchwork-Id: 132055 Message-Id: <201112180832.pBI8WaNQ015545@ignucius.se.axis.com> To: Tom_deVries@mentor.com Cc: vries@codesourcery.com, gcc-patches@gcc.gnu.org > From: Tom de Vries > Date: Thu, 15 Dec 2011 10:23:27 +0100 > bootstrapped and reg-tested (ada inclusive) on x86_64. Time to update your inspection script: there's a missing sanity check for the number of passes. I suggest you re-run regtests for the main change with the below patch applied. > 2011-12-15 Tom de Vries > * gcc.dg/pr51491.c: New test. > * gcc.dg/pr51491-2.c: Same. > Index: gcc/testsuite/gcc.dg/pr51491-2.c > +/* { dg-final { cleanup-treee-dump "ccp1" } } */ Typos like this cause the test-run to be aborted for the current .exp file, in this case, gcc/testsuite/gcc.dg/dg.exp: ERROR: (DejaGnu) proc "cleanup-treee-dump ccp1" does not exist. The error code is NONE The info on the error is: close: spawn id exp5 not open while executing "close -i exp5" invoked from within "catch "close -i $spawn_id"" In this case, some 3000 test-cases went missing, judging by the "gcc Summary" output. Below patch committed as obvious after verifying that it fixed the error. gcc/testsuite: * gcc.dg/pr51491-2.c: Fix "cleanup-treee-dump" typo. brgds, H-P Index: gcc/testsuite/gcc.dg/pr51491-2.c =================================================================== --- gcc/testsuite/gcc.dg/pr51491-2.c (revision 182453) +++ gcc/testsuite/gcc.dg/pr51491-2.c (working copy) @@ -31,4 +31,4 @@ f (int n) } /* { dg-final { scan-tree-dump-times "CLOBBER" 2 "ccp1"} } */ -/* { dg-final { cleanup-treee-dump "ccp1" } } */ +/* { dg-final { cleanup-tree-dump "ccp1" } } */