Patchwork [U-Boot] kirkwood_spi: fix setting of irq mask

login
register
mail settings
Submitter Michael Walle
Date Dec. 17, 2011, 5:28 p.m.
Message ID <1324142885-10701-1-git-send-email-michael@walle.cc>
Download mbox | patch
Permalink /patch/132018/
State Accepted
Commit 3f8435516b1c27c7fdf75ace1de1391d119c65c4
Headers show

Comments

Michael Walle - Dec. 17, 2011, 5:28 p.m.
Since the data alignment fault was enabled recently in commit
  arm, arm926ejs: always do cpu critical inits
the driver won't work anymore and all boards which use an environment in an
SPI flash will fail booting.

Signed-off-by: Michael Walle <michael@walle.cc>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Cc: Prafulla Wadaskar <prafulla@marvell.com>
---
 drivers/spi/kirkwood_spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Michael Walle - Dec. 17, 2011, 5:31 p.m.
Am Samstag 17 Dezember 2011, 18:28:05 schrieb Michael Walle:
> Since the data alignment fault was enabled recently in commit
>   arm, arm926ejs: always do cpu critical inits
> the driver won't work anymore and all boards which use an environment in an
> SPI flash will fail booting.

Sorry i don't know how you track patches that should be applied for the RC. 
But IMHO this is one :)
Prafulla Wadaskar - Dec. 18, 2011, 1:57 a.m.
> -----Original Message-----
> From: Michael Walle [mailto:michael@walle.cc]
> Sent: 17 December 2011 09:31
> To: u-boot@lists.denx.de
> Cc: Albert ARIBAUD; Prafulla Wadaskar; Wolfgang Denk
> Subject: Re: [PATCH] kirkwood_spi: fix setting of irq mask
> 
> Am Samstag 17 Dezember 2011, 18:28:05 schrieb Michael Walle:
> > Since the data alignment fault was enabled recently in commit
> >   arm, arm926ejs: always do cpu critical inits
> > the driver won't work anymore and all boards which use an
> environment in an
> > SPI flash will fail booting.
> 
> Sorry i don't know how you track patches that should be applied for
> the RC.
> But IMHO this is one :)

Thanks Michael
I will take care of that.

Regards..
Prafulla . . .

> 
> --
> Michael
Michael Walle - Jan. 2, 2012, 6:38 p.m.
Am Sonntag 18 Dezember 2011, 02:57:01 schrieb Prafulla Wadaskar:
> > -----Original Message-----
> > From: Michael Walle [mailto:michael@walle.cc]
> > Sent: 17 December 2011 09:31
> > To: u-boot@lists.denx.de
> > Cc: Albert ARIBAUD; Prafulla Wadaskar; Wolfgang Denk
> > Subject: Re: [PATCH] kirkwood_spi: fix setting of irq mask
> > 
> > Am Samstag 17 Dezember 2011, 18:28:05 schrieb Michael Walle:
> > > Since the data alignment fault was enabled recently in commit
> > > 
> > >   arm, arm926ejs: always do cpu critical inits
> > > 
> > > the driver won't work anymore and all boards which use an
> > 
> > environment in an
> > 
> > > SPI flash will fail booting.
> > 
> > Sorry i don't know how you track patches that should be applied for
> > the RC.
> > But IMHO this is one :)
> 
> Thanks Michael
> I will take care of that.
Ping :)

Patch

diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
index a50e498..9aaecfe 100644
--- a/drivers/spi/kirkwood_spi.c
+++ b/drivers/spi/kirkwood_spi.c
@@ -67,7 +67,7 @@  struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
 	debug("data = 0x%08x \n", data);
 
 	writel(KWSPI_SMEMRDIRQ, &spireg->irq_cause);
-	writel(KWSPI_IRQMASK, spireg->irq_mask);
+	writel(KWSPI_IRQMASK, &spireg->irq_mask);
 
 	/* program mpp registers to select  SPI_CSn */
 	if (cs) {