Patchwork [04/24] libsas: remove unused ata_task_resp fields

login
register
mail settings
Submitter Dan Williams
Date Dec. 17, 2011, 2:33 a.m.
Message ID <20111217023328.15036.65227.stgit@localhost6.localdomain6>
Download mbox | patch
Permalink /patch/131953/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Dan Williams - Dec. 17, 2011, 2:33 a.m.
Commit 1e34c838 removed the routines to fake the presence of the sata
control registers, now remove the unused data structure fields to kill
any remaining confusion.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/scsi/libsas/sas_ata.c |    4 ----
 include/scsi/libsas.h         |    7 -------
 2 files changed, 0 insertions(+), 11 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov - Dec. 17, 2011, 12:51 p.m.
Hello.

On 17-12-2011 6:33, Dan Williams wrote:

> Commit 1e34c838 removed the routines to fake the presence of the sata

    Please also specify that commit's summary (in parens).

> control registers, now remove the unused data structure fields to kill
> any remaining confusion.

> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jack Wang - Dec. 19, 2011, 1:38 a.m.
> 

[Jack Wang] 
Thanks for looking for this, looks OK for me.
Acked-by: Jack Wang <jack_wang@usish.com>
> Commit 1e34c838 removed the routines to fake the presence of the sata
> control registers, now remove the unused data structure fields to kill
> any remaining confusion.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/scsi/libsas/sas_ata.c |    4 ----
>  include/scsi/libsas.h         |    7 -------
>  2 files changed, 0 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index db9238f..83118d0 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -121,10 +121,6 @@ static void sas_ata_task_done(struct sas_task *task)
>  			if (unlikely(link->eh_info.err_mask))
>  				qc->flags |= ATA_QCFLAG_FAILED;
>  		}
> -
> -		dev->sata_dev.sstatus = resp->sstatus;
> -		dev->sata_dev.serror = resp->serror;
> -		dev->sata_dev.scontrol = resp->scontrol;
>  	} else {
>  		ac = sas_to_ata_err(stat);
>  		if (ac) {
> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
> index 6a308d4..6e64b03 100644
> --- a/include/scsi/libsas.h
> +++ b/include/scsi/libsas.h
> @@ -171,9 +171,6 @@ struct sata_device {
>  	struct ata_port *ap;
>  	struct ata_host ata_host;
>  	struct ata_taskfile tf;
> -	u32 sstatus;
> -	u32 serror;
> -	u32 scontrol;
>  };
> 
>  /* ---------- Domain device ---------- */
> @@ -487,10 +484,6 @@ enum exec_status {
>  struct ata_task_resp {
>  	u16  frame_len;
>  	u8   ending_fis[24];	  /* dev to host or data-in */
> -	u32  sstatus;
> -	u32  serror;
> -	u32  scontrol;
> -	u32  sactive;
>  };
> 
>  #define SAS_STATUS_BUF_SIZE 96
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index db9238f..83118d0 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -121,10 +121,6 @@  static void sas_ata_task_done(struct sas_task *task)
 			if (unlikely(link->eh_info.err_mask))
 				qc->flags |= ATA_QCFLAG_FAILED;
 		}
-
-		dev->sata_dev.sstatus = resp->sstatus;
-		dev->sata_dev.serror = resp->serror;
-		dev->sata_dev.scontrol = resp->scontrol;
 	} else {
 		ac = sas_to_ata_err(stat);
 		if (ac) {
diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
index 6a308d4..6e64b03 100644
--- a/include/scsi/libsas.h
+++ b/include/scsi/libsas.h
@@ -171,9 +171,6 @@  struct sata_device {
 	struct ata_port *ap;
 	struct ata_host ata_host;
 	struct ata_taskfile tf;
-	u32 sstatus;
-	u32 serror;
-	u32 scontrol;
 };
 
 /* ---------- Domain device ---------- */
@@ -487,10 +484,6 @@  enum exec_status {
 struct ata_task_resp {
 	u16  frame_len;
 	u8   ending_fis[24];	  /* dev to host or data-in */
-	u32  sstatus;
-	u32  serror;
-	u32  scontrol;
-	u32  sactive;
 };
 
 #define SAS_STATUS_BUF_SIZE 96