Patchwork [v3] mtd/docg3: fixes and cleanups

login
register
mail settings
Submitter Robert Jarzmik
Date Dec. 16, 2011, 10:25 p.m.
Message ID <87pqfow3vw.fsf@free.fr>
Download mbox | patch
Permalink /patch/131923/
State New
Headers show

Comments

Robert Jarzmik - Dec. 16, 2011, 10:25 p.m.
> Artem Bityutskiy <dedekind1@gmail.com> writes:
>
>> On Fri, 2011-12-09 at 17:13 +0100, Robert Jarzmik wrote:
>> May be it is better to just embrace this function with "#ifdef 0" and add a
>> comment that we can do this but do not have a good use for this?
> Ah yes, I didn't think about that possibility. It's looks better, I'll submit
> another patch with a comment and the #if 0.
How about the following patch ?

Cheers.
Artem Bityutskiy - Dec. 17, 2011, 3:08 p.m.
On Fri, 2011-12-16 at 23:25 +0100, Robert Jarzmik wrote:
> > Artem Bityutskiy <dedekind1@gmail.com> writes:
> >
> >> On Fri, 2011-12-09 at 17:13 +0100, Robert Jarzmik wrote:
> >> May be it is better to just embrace this function with "#ifdef 0" and add a
> >> comment that we can do this but do not have a good use for this?
> > Ah yes, I didn't think about that possibility. It's looks better, I'll submit
> > another patch with a comment and the #if 0.
> How about the following patch ?

Pushed to l2-mtd-2.6.git, thanks!

Patch

diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
index 2a32072..22d5099 100644
--- a/drivers/mtd/devices/docg3.c
+++ b/drivers/mtd/devices/docg3.c
@@ -1037,6 +1037,7 @@  static int doc_block_isbad(struct mtd_info *mtd, loff_t from)
 	return !is_good;
 }
 
+#if 0
 /**
  * doc_get_erase_count - Get block erase count
  * @docg3: the device
@@ -1078,6 +1079,7 @@  static int doc_get_erase_count(struct docg3 *docg3, loff_t from)
 
 	return max(plane1_erase_count, plane2_erase_count);
 }
+#endif
 
 /**
  * doc_get_op_status - get erase/write operation status