| Message ID | 1324036918-2405-4-git-send-email-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 12/16/2011 06:01 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini<pbonzini@redhat.com> Yeah, this code path is currently dead as there is no way to test it until we defer s/init/realize/ and defer it to guest launch. In my next series when I introduce Object and move properties into it, we can write some unit tests to cover this sort of thing. Reviewed-by: Anthony Liguori <aliguori@us.ibm.com> Regards, Anthony Liguori > --- > hw/qdev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/qdev.c b/hw/qdev.c > index 83913c7..bda8d6c 100644 > --- a/hw/qdev.c > +++ b/hw/qdev.c > @@ -1110,7 +1110,7 @@ void qdev_property_set(DeviceState *dev, Visitor *v, const char *name, > if (!prop->set) { > error_set(errp, QERR_PERMISSION_DENIED); > } else { > - prop->set(dev, prop->opaque, v, name, errp); > + prop->set(dev, v, prop->opaque, name, errp); > } > } >
diff --git a/hw/qdev.c b/hw/qdev.c index 83913c7..bda8d6c 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -1110,7 +1110,7 @@ void qdev_property_set(DeviceState *dev, Visitor *v, const char *name, if (!prop->set) { error_set(errp, QERR_PERMISSION_DENIED); } else { - prop->set(dev, prop->opaque, v, name, errp); + prop->set(dev, v, prop->opaque, name, errp); } }
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- hw/qdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)