Patchwork wimax/i2400m: remove an unused variable

login
register
mail settings
Submitter Dan Carpenter
Date Dec. 16, 2011, 10:22 a.m.
Message ID <20111216102242.GC4287@elgon.mountain>
Download mbox | patch
Permalink /patch/131799/
State Accepted
Delegated to: David Miller
Headers show

Comments

Dan Carpenter - Dec. 16, 2011, 10:22 a.m.
"result" isn't used.  We ignore errors here because there is not much we
can do about them.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Perez-Gonzalez, Inaky - Dec. 16, 2011, 10:09 p.m.
> Subject: [patch] wimax/i2400m: remove an unused variable
> 
> "result" isn't used.  We ignore errors here because there is not much
> we can do about them.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

This is an ACK or a NAK depending on if you want to keep the reporting
with debug enabled or not. It is not so difficult to add back if needed, 
so I tend to ACK.

Thank you,
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Dec. 17, 2011, 12:07 a.m.
From: "Perez-Gonzalez, Inaky" <inaky.perez-gonzalez@intel.com>
Date: Fri, 16 Dec 2011 22:09:29 +0000

>> Subject: [patch] wimax/i2400m: remove an unused variable
>> 
>> "result" isn't used.  We ignore errors here because there is not much
>> we can do about them.
>> 
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> This is an ACK or a NAK depending on if you want to keep the reporting
> with debug enabled or not. It is not so difficult to add back if needed, 
> so I tend to ACK.

And FWIW I applied this to net-next already.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/wimax/i2400m/usb-tx.c b/drivers/net/wimax/i2400m/usb-tx.c
index ac357ac..99ef81b 100644
--- a/drivers/net/wimax/i2400m/usb-tx.c
+++ b/drivers/net/wimax/i2400m/usb-tx.c
@@ -177,7 +177,6 @@  retry:
 static
 int i2400mu_txd(void *_i2400mu)
 {
-	int result = 0;
 	struct i2400mu *i2400mu = _i2400mu;
 	struct i2400m *i2400m = &i2400mu->i2400m;
 	struct device *dev = &i2400mu->usb_iface->dev;
@@ -208,16 +207,14 @@  int i2400mu_txd(void *_i2400mu)
 		/* Yeah, we ignore errors ... not much we can do */
 		i2400mu_tx(i2400mu, tx_msg, tx_msg_size);
 		i2400m_tx_msg_sent(i2400m);	/* ack it, advance the FIFO */
-		if (result < 0)
-			break;
 	}
 
 	spin_lock_irqsave(&i2400m->tx_lock, flags);
 	i2400mu->tx_kthread = NULL;
 	spin_unlock_irqrestore(&i2400m->tx_lock, flags);
 
-	d_fnend(4, dev, "(i2400mu %p) = %d\n", i2400mu, result);
-	return result;
+	d_fnend(4, dev, "(i2400mu %p)\n", i2400mu);
+	return 0;
 }