Patchwork [U-Boot] add missing space

login
register
mail settings
Submitter Luka Perkov
Date Dec. 15, 2011, 11:32 p.m.
Message ID <20111215233215.GB21725@w500.lan>
Download mbox | patch
Permalink /patch/131780/
State Rejected
Headers show

Comments

Luka Perkov - Dec. 15, 2011, 11:32 p.m.
Cosmetic patch for first U-Boot line that gets printed.

Signed-off-by: Luka Perkov <lists@lukaperkov.net>
---
Anatolij Gustschin - Dec. 16, 2011, 12:13 p.m.
Hi Luka,

On Fri, 16 Dec 2011 00:32:15 +0100
Luka Perkov <lists@lukaperkov.net> wrote:

> Cosmetic patch for first U-Boot line that gets printed.
> 
> Signed-off-by: Luka Perkov <lists@lukaperkov.net>
> ---
> diff --git a/include/version.h b/include/version.h
> index c908bd3..ac5a39a 100644
> --- a/include/version.h
> +++ b/include/version.h
> @@ -35,7 +35,7 @@
>  #endif
>  
>  #define U_BOOT_VERSION_STRING U_BOOT_VERSION " (" U_BOOT_DATE " - " \
> -	U_BOOT_TIME ")" CONFIG_IDENT_STRING
> +	U_BOOT_TIME ") " CONFIG_IDENT_STRING

This change is not needed I think. Most boards defining
CONFIG_IDENT_STRING use either a string starting with new line or
strings like " something". So this patch will deface version string.
Your CONFIG_IDENT_STRING should be fixed instead.

Thanks,
Anatolij
Mike Frysinger - Dec. 16, 2011, 3:59 p.m.
On Friday 16 December 2011 07:13:47 Anatolij Gustschin wrote:
> On Fri, 16 Dec 2011 00:32:15 +0100 Luka Perkov wrote:
> > Cosmetic patch for first U-Boot line that gets printed.
> > 
> > --- a/include/version.h
> > +++ b/include/version.h
> > 
> >  #define U_BOOT_VERSION_STRING U_BOOT_VERSION " (" U_BOOT_DATE " - " \
> > -	U_BOOT_TIME ")" CONFIG_IDENT_STRING
> > +	U_BOOT_TIME ") " CONFIG_IDENT_STRING
> 
> This change is not needed I think. Most boards defining
> CONFIG_IDENT_STRING use either a string starting with new line or
> strings like " something". So this patch will deface version string.
> Your CONFIG_IDENT_STRING should be fixed instead.

+1
-mike
Mike Frysinger - Dec. 16, 2011, 11:49 p.m.
On Friday 16 December 2011 18:43:18 Luka Perkov wrote:
> On Fri, Dec 16, 2011 at 10:59:03AM -0500, Mike Frysinger wrote:
> > On Friday 16 December 2011 07:13:47 Anatolij Gustschin wrote:
> > > On Fri, 16 Dec 2011 00:32:15 +0100 Luka Perkov wrote:
> > > > Cosmetic patch for first U-Boot line that gets printed.
> > > > 
> > > > --- a/include/version.h
> > > > +++ b/include/version.h
> > > > 
> > > >  #define U_BOOT_VERSION_STRING U_BOOT_VERSION " (" U_BOOT_DATE " - "
> > > >  \
> > > > 
> > > > -	U_BOOT_TIME ")" CONFIG_IDENT_STRING
> > > > +	U_BOOT_TIME ") " CONFIG_IDENT_STRING
> > > 
> > > This change is not needed I think. Most boards defining
> > > CONFIG_IDENT_STRING use either a string starting with new line or
> > > strings like " something". So this patch will deface version string.
> > > Your CONFIG_IDENT_STRING should be fixed instead.
> > 
> > +1
> > -mike
> 
> Ok, thanks for pointing this out. I guess that something like patch
> bellow is not acceptable?

no, because you're adding a useless space for everyone who doesn't define 
CONFIG_IDENT_STRING :)
-mike

Patch

diff --git a/include/version.h b/include/version.h
index c908bd3..ac5a39a 100644
--- a/include/version.h
+++ b/include/version.h
@@ -35,7 +35,7 @@ 
 #endif
 
 #define U_BOOT_VERSION_STRING U_BOOT_VERSION " (" U_BOOT_DATE " - " \
-	U_BOOT_TIME ")" CONFIG_IDENT_STRING
+	U_BOOT_TIME ") " CONFIG_IDENT_STRING
 
 #ifndef __ASSEMBLY__
 extern const char version_string[];